Skip to content
Snippets Groups Projects
  1. Sep 22, 2017
  2. Sep 21, 2017
  3. Sep 20, 2017
    • Peter Maydell's avatar
      Merge remote-tracking branch 'remotes/gkurz/tags/for-upstream' into staging · b62b7ed0
      Peter Maydell authored
      
      These patches fix regressions in 2.10
      
      # gpg: Signature made Wed 20 Sep 2017 07:51:07 BST
      # gpg:                using DSA key 0x02FC3AEB0101DBC2
      # gpg: Good signature from "Greg Kurz <groug@kaod.org>"
      # gpg:                 aka "Greg Kurz <groug@free.fr>"
      # gpg:                 aka "Greg Kurz <gkurz@linux.vnet.ibm.com>"
      # gpg:                 aka "Gregory Kurz (Groug) <groug@free.fr>"
      # gpg:                 aka "[jpeg image of size 3330]"
      # gpg: WARNING: This key is not certified with a trusted signature!
      # gpg:          There is no indication that the signature belongs to the owner.
      # Primary key fingerprint: 2BD4 3B44 535E C0A7 9894  DBA2 02FC 3AEB 0101 DBC2
      
      * remotes/gkurz/tags/for-upstream:
        9pfs: check the size of transport buffer before marshaling
        9pfs: fix name_to_path assertion in v9fs_complete_rename()
        9pfs: fix readdir() for 9p2000.u
      
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      b62b7ed0
    • Peter Maydell's avatar
      Merge remote-tracking branch 'remotes/ehabkost/tags/machine-next-pull-request' into staging · d3f5433c
      Peter Maydell authored
      
      Machine/CPU/NUMA queue, 2017-09-19
      
      # gpg: Signature made Tue 19 Sep 2017 21:17:01 BST
      # gpg:                using RSA key 0x2807936F984DC5A6
      # gpg: Good signature from "Eduardo Habkost <ehabkost@redhat.com>"
      # Primary key fingerprint: 5A32 2FD5 ABC4 D3DB ACCF  D1AA 2807 936F 984D C5A6
      
      * remotes/ehabkost/tags/machine-next-pull-request:
        MAINTAINERS: Update git URLs for my trees
        hw/acpi-build: Fix SRAT memory building in case of node 0 without RAM
        NUMA: Replace MAX_NODES with nb_numa_nodes in for loop
        numa: cpu: calculate/set default node-ids after all -numa CLI options are parsed
        arm: drop intermediate cpu_model -> cpu type parsing and use cpu type directly
        pc: use generic cpu_model parsing
        vl.c: convert cpu_model to cpu type and set of global properties before machine_init()
        cpu: make cpu_generic_init() abort QEMU on error
        qom: cpus: split cpu_generic_init() on feature parsing and cpu creation parts
        hostmem-file: Add "discard-data" option
        osdep: Define QEMU_MADV_REMOVE
        vl: Clean up user-creatable objects when exiting
      
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      d3f5433c
    • Jan Dakinevich's avatar
      9pfs: check the size of transport buffer before marshaling · 772a7369
      Jan Dakinevich authored
      
      v9fs_do_readdir_with_stat() should check for a maximum buffer size
      before an attempt to marshal gathered data. Otherwise, buffers assumed
      as misconfigured and the transport would be broken.
      
      The patch brings v9fs_do_readdir_with_stat() in conformity with
      v9fs_do_readdir() behavior.
      
      Signed-off-by: default avatarJan Dakinevich <jan.dakinevich@gmail.com>
      [groug, regression caused my commit 8d37de41 # 2.10]
      Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
      772a7369
    • Jan Dakinevich's avatar
      9pfs: fix name_to_path assertion in v9fs_complete_rename() · 4d8bc733
      Jan Dakinevich authored
      
      The third parameter of v9fs_co_name_to_path() must not contain `/'
      character.
      
      The issue is most likely related to 9p2000.u protocol only.
      
      Signed-off-by: default avatarJan Dakinevich <jan.dakinevich@gmail.com>
      [groug, regression caused by commit f57f5878 # 2.10]
      Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
      4d8bc733
    • Jan Dakinevich's avatar
      9pfs: fix readdir() for 9p2000.u · 6069537f
      Jan Dakinevich authored
      
      If the client is using 9p2000.u, the following occurs:
      
      $ cd ${virtfs_shared_dir}
      $ mkdir -p a/b/c
      $ ls a/b
      ls: cannot access 'a/b/a': No such file or directory
      ls: cannot access 'a/b/b': No such file or directory
      a  b  c
      
      instead of the expected:
      
      $ ls a/b
      c
      
      This is a regression introduced by commit f57f5878;
      local_name_to_path() now resolves ".." and "." in paths,
      and v9fs_do_readdir_with_stat()->stat_to_v9stat() then
      copies the basename of the resulting path to the response.
      With the example above, this means that "." and ".." are
      turned into "b" and "a" respectively...
      
      stat_to_v9stat() currently assumes it is passed a full
      canonicalized path and uses it to do two different things:
      1) to pass it to v9fs_co_readlink() in case the file is a symbolic
         link
      2) to set the name field of the V9fsStat structure to the basename
         part of the given path
      
      It only has two users: v9fs_stat() and v9fs_do_readdir_with_stat().
      
      v9fs_stat() really needs 1) and 2) to be performed since it starts
      with the full canonicalized path stored in the fid. It is different
      for v9fs_do_readdir_with_stat() though because the name we want to
      put into the V9fsStat structure is the d_name field of the dirent
      actually (ie, we want to keep the "." and ".." special names). So,
      we only need 1) in this case.
      
      This patch hence adds a basename argument to stat_to_v9stat(), to
      be used to set the name field of the V9fsStat structure, and moves
      the basename logic to v9fs_stat().
      
      Signed-off-by: default avatarJan Dakinevich <jan.dakinevich@gmail.com>
      (groug, renamed old name argument to path and updated changelog)
      Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
      6069537f
  4. Sep 19, 2017
Loading