Skip to content
Snippets Groups Projects
  1. Mar 10, 2023
  2. Feb 16, 2023
  3. Jan 11, 2023
  4. Dec 14, 2022
    • Markus Armbruster's avatar
      cleanup: Tweak and re-run return_directly.cocci · 66997c42
      Markus Armbruster authored
      
      Tweak the semantic patch to drop redundant parenthesis around the
      return expression.
      
      Coccinelle drops a comment in hw/rdma/vmw/pvrdma_cmd.c; restored
      manually.
      
      Coccinelle messes up vmdk_co_create(), not sure why.  Change dropped,
      will be done manually in the next commit.
      
      Line breaks in target/avr/cpu.h and hw/rdma/vmw/pvrdma_cmd.c tidied up
      manually.
      
      Whitespace in tools/virtiofsd/fuse_lowlevel.c tidied up manually.
      
      checkpatch.pl complains "return of an errno should typically be -ve"
      two times for hw/9pfs/9p-synth.c.  Preexisting, the patch merely makes
      it visible to checkpatch.pl.
      
      Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
      Message-Id: <20221122134917.1217307-2-armbru@redhat.com>
      Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
      Acked-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
      66997c42
  5. Nov 25, 2022
  6. Sep 22, 2022
  7. Aug 04, 2022
  8. Aug 02, 2022
    • Vivek Goyal's avatar
      virtiofsd: Disable killpriv_v2 by default · a21ba54d
      Vivek Goyal authored
      
      We are having bunch of issues with killpriv_v2 enabled by default. First
      of all it relies on clearing suid/sgid bits as needed by dropping
      capability CAP_FSETID. This does not work for remote filesystems like
      NFS (and possibly others).
      
      Secondly, we are noticing other issues related to clearing of SGID
      which leads to failures for xfstests generic/355 and generic/193.
      
      Thirdly, there are other issues w.r.t caching of metadata (suid/sgid)
      bits in fuse client with killpriv_v2 enabled. Guest can cache that
      data for sometime even if cleared on server.
      
      Second and Third issue are fixable. Just that it might take a little
      while to get it fixed in kernel. First one will probably not see
      any movement for a long time.
      
      Given these issues, killpriv_v2 does not seem to be a good candidate
      for enabling by default. We have already disabled it by default in
      rust version of virtiofsd.
      
      Hence this patch disabled killpriv_v2 by default. User can choose to
      enable it by passing option "-o killpriv_v2".
      
      Signed-off-by: default avatarVivek Goyal <vgoyal@redhat.com>
      Message-Id: <YuPd0itNIAz4tQRt@redhat.com>
      Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
      Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
      a21ba54d
  9. Aug 01, 2022
  10. Jun 28, 2022
  11. May 11, 2022
  12. May 07, 2022
  13. May 03, 2022
  14. Apr 21, 2022
  15. Mar 02, 2022
  16. Feb 17, 2022
  17. Feb 16, 2022
    • Sebastian Hasler's avatar
      virtiofsd: Do not support blocking flock · 41af4459
      Sebastian Hasler authored
      
      With the current implementation, blocking flock can lead to
      deadlock. Thus, it's better to return EOPNOTSUPP if a user attempts
      to perform a blocking flock request.
      
      Signed-off-by: default avatarSebastian Hasler <sebastian.hasler@stuvus.uni-stuttgart.de>
      Message-Id: <20220113153249.710216-1-sebastian.hasler@stuvus.uni-stuttgart.de>
      Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
      Reviewed-by: default avatarVivek Goyal <vgoyal@redhat.com>
      Reviewed-by: default avatarGreg Kurz <groug@kaod.org>
      41af4459
    • Paolo Bonzini's avatar
      meson: use .require() and .disable_auto_if() method for features · a436d6d4
      Paolo Bonzini authored
      
      The method is now in 0.59, using it simplifies some conditionals.
      
      There is a small change, which is to build virtfs-proxy-helper in a
      tools-only build.  This is done for consistency with other tools,
      which are not culled by the absence of system emulator binaries.
      
      .disable_auto_if() would also be useful to check for packages,
      for example
      
      -linux_io_uring = not_found
      -if not get_option('linux_io_uring').auto() or have_block
      -  linux_io_uring = dependency('liburing', required: get_option('linux_io_uring'),
      -                              method: 'pkg-config', kwargs: static_kwargs)
      -endif
      +linux_io_uring = dependency('liburing',
      +  required: get_option('linux_io_uring').disable_auto_if(not have_block),
      +  method: 'pkg-config', kwargs: static_kwargs)
      
      This change however is much larger and I am not sure about the improved
      readability, so I am not performing it right now.
      
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      a436d6d4
  18. Feb 14, 2022
  19. Jan 26, 2022
  20. Oct 25, 2021
  21. Sep 16, 2021
    • Sergio Lopez's avatar
      virtiofsd: Reverse req_list before processing it · 046d91c8
      Sergio Lopez authored
      
      With the thread pool disabled, we add the requests in the queue to a
      GList, processing by iterating over there afterwards.
      
      For adding them, we're using "g_list_prepend()", which is more
      efficient but causes the requests to be processed in reverse order,
      breaking the read-ahead and request-merging optimizations in the host
      for sequential operations.
      
      According to the documentation, if you need to process the request
      in-order, using "g_list_prepend()" and then reversing the list with
      "g_list_reverse()" is more efficient than using "g_list_append()", so
      let's do it that way.
      
      Testing on a spinning disk (to boost the increase of read-ahead and
      request-merging) shows a 4x improvement on sequential write fio test:
      
      Test:
      fio --directory=/mnt/virtio-fs --filename=fio-file1 --runtime=20
      --iodepth=16 --size=4G --direct=1 --blocksize=4K --ioengine libaio
      --rw write --name seqwrite-libaio
      
      Without "g_list_reverse()":
      ...
      Jobs: 1 (f=1): [W(1)][100.0%][w=22.4MiB/s][w=5735 IOPS][eta 00m:00s]
      seqwrite-libaio: (groupid=0, jobs=1): err= 0: pid=710: Tue Aug 24 12:58:16 2021
        write: IOPS=5709, BW=22.3MiB/s (23.4MB/s)(446MiB/20002msec); 0 zone resets
      ...
      
      With "g_list_reverse()":
      ...
      Jobs: 1 (f=1): [W(1)][100.0%][w=84.0MiB/s][w=21.5k IOPS][eta 00m:00s]
      seqwrite-libaio: (groupid=0, jobs=1): err= 0: pid=716: Tue Aug 24 13:00:15 2021
        write: IOPS=21.3k, BW=83.1MiB/s (87.2MB/s)(1663MiB/20001msec); 0 zone resets
      ...
      
      Signed-off-by: default avatarSergio Lopez <slp@redhat.com>
      Message-Id: <20210824131158.39970-1-slp@redhat.com>
      Reviewed-by: default avatarVivek Goyal <vgoyal@redhat.com>
      Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
      046d91c8
    • Thomas Huth's avatar
      tools/virtiofsd: Add fstatfs64 syscall to the seccomp allowlist · 8cfd339b
      Thomas Huth authored
      The virtiofsd currently crashes on s390x when doing something like
      this in the guest:
      
       mkdir -p /mnt/myfs
       mount -t virtiofs myfs /mnt/myfs
       touch /mnt/myfs/foo.txt
       stat -f /mnt/myfs/foo.txt
      
      The problem is that the fstatfs64 syscall is called in this case
      from the virtiofsd. We have to put it on the seccomp allowlist to
      avoid that the daemon gets killed in this case.
      
      Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2001728
      
      
      Suggested-by: default avatarVivek Goyal <vgoyal@redhat.com>
      Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
      Message-Id: <20210914123214.181885-1-thuth@redhat.com>
      Reviewed-by: default avatarVivek Goyal <vgoyal@redhat.com>
      Reviewed-by: default avatarSergio Lopez <slp@redhat.com>
      Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
      8cfd339b
  22. Sep 15, 2021
Loading