Skip to content
Snippets Groups Projects
  1. Dec 09, 2021
  2. Dec 08, 2021
    • David Taylor's avatar
      DEV: Fallback to locale strings for name/title (#45) · f0a76061
      David Taylor authored
      This means that the name/title can be set per-site and per-locale. This change is backwards-compatible - any existing sites which have configured the GlobalSettings will use those cluster-wide.
      f0a76061
    • David Taylor's avatar
      DEV: Move `saml_request_method` handling into the OmniAuth strategy (#44) · 95ccea3f
      David Taylor authored
      Putting this logic into the omniauth strategy is much cleaner because:
      - we no longer need a Rails controller and the associated `custom_url` parameter
      - we can re-use the `authn_request` instance which is automatically generated by the omniauth strategy, rather than re-implementing that logic
      - the behavior is decided at runtime, rather than during initialization. This makes it testable, and is another step on the way to making the plugin multisite-compatible
      
      This commit also introduces a spec for the feature.
      95ccea3f
    • David Taylor's avatar
      DEV: Configure Omniauth strategy at runtime (#43) · 12cae03c
      David Taylor authored
      This will allow much easier testing of the strategy, and is one more step towards making the SAML plugin multisite-compatible
      12cae03c
  3. Dec 07, 2021
    • David Taylor's avatar
      FIX: Update name selection logic (#42) · 9b079332
      David Taylor authored
      For `name`, the previous intention was to use the `fullName` attribute, and then fallback to "firstname lastname". However, a bug in the implementation meant that the `fullName` was skipped.
      
      This commit updates the logic to lean on omniauth-saml's attribute_statements for the fullName, firstName and lastName attributes, and also updates the priority logic so that fullName is indeed prioritized.
      9b079332
  4. Dec 06, 2021
  5. Oct 27, 2021
  6. Oct 21, 2021
  7. Sep 27, 2021
  8. Sep 24, 2021
  9. Sep 22, 2021
  10. Jul 27, 2021
  11. Jul 23, 2021
  12. Mar 25, 2021
  13. Nov 12, 2020
  14. Jun 05, 2020
  15. Apr 29, 2020
  16. Apr 23, 2020
  17. Apr 17, 2020
  18. Apr 07, 2020
  19. Feb 04, 2020
  20. Jan 07, 2020
  21. Nov 27, 2019
  22. Nov 25, 2019
  23. Nov 18, 2019
  24. Nov 13, 2019
  25. Sep 12, 2019
  26. Sep 11, 2019
  27. Jun 26, 2019
Loading