Skip to content
Snippets Groups Projects
Unverified Commit 95ccea3f authored by David Taylor's avatar David Taylor Committed by GitHub
Browse files

DEV: Move `saml_request_method` handling into the OmniAuth strategy (#44)

Putting this logic into the omniauth strategy is much cleaner because:
- we no longer need a Rails controller and the associated `custom_url` parameter
- we can re-use the `authn_request` instance which is automatically generated by the omniauth strategy, rather than re-implementing that logic
- the behavior is decided at runtime, rather than during initialization. This makes it testable, and is another step on the way to making the plugin multisite-compatible

This commit also introduces a spec for the feature.
parent 12cae03c
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment