Skip to content
Snippets Groups Projects
  1. Mar 14, 2023
    • Matheus Tavares Bernardino's avatar
      io/channel-tls: plug memory leakage on GSource · c3a2c84a
      Matheus Tavares Bernardino authored
      
      This leakage can be seen through test-io-channel-tls:
      
      $ ../configure --target-list=aarch64-softmmu --enable-sanitizers
      $ make ./tests/unit/test-io-channel-tls
      $ ./tests/unit/test-io-channel-tls
      
      Indirect leak of 104 byte(s) in 1 object(s) allocated from:
          #0 0x7f81d1725808 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cc:144
          #1 0x7f81d135ae98 in g_malloc (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x57e98)
          #2 0x55616c5d4c1b in object_new_with_propv ../qom/object.c:795
          #3 0x55616c5d4a83 in object_new_with_props ../qom/object.c:768
          #4 0x55616c5c5415 in test_tls_creds_create ../tests/unit/test-io-channel-tls.c:70
          #5 0x55616c5c5a6b in test_io_channel_tls ../tests/unit/test-io-channel-tls.c:158
          #6 0x7f81d137d58d  (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x7a58d)
      
      Indirect leak of 32 byte(s) in 1 object(s) allocated from:
          #0 0x7f81d1725a06 in __interceptor_calloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cc:153
          #1 0x7f81d1472a20 in gnutls_dh_params_init (/lib/x86_64-linux-gnu/libgnutls.so.30+0x46a20)
          #2 0x55616c6485ff in qcrypto_tls_creds_x509_load ../crypto/tlscredsx509.c:634
          #3 0x55616c648ba2 in qcrypto_tls_creds_x509_complete ../crypto/tlscredsx509.c:694
          #4 0x55616c5e1fea in user_creatable_complete ../qom/object_interfaces.c:28
          #5 0x55616c5d4c8c in object_new_with_propv ../qom/object.c:807
          #6 0x55616c5d4a83 in object_new_with_props ../qom/object.c:768
          #7 0x55616c5c5415 in test_tls_creds_create ../tests/unit/test-io-channel-tls.c:70
          #8 0x55616c5c5a6b in test_io_channel_tls ../tests/unit/test-io-channel-tls.c:158
          #9 0x7f81d137d58d  (/lib/x86_64-linux-gnu/libglib-2.0.so.0+0x7a58d)
      
      ...
      
      SUMMARY: AddressSanitizer: 49143 byte(s) leaked in 184 allocation(s).
      
      The docs for `g_source_add_child_source(source, child_source)` says
      "source will hold a reference on child_source while child_source is
      attached to it." Therefore, we should unreference the child source at
      `qio_channel_tls_read_watch()` after attaching it to `source`. With this
      change, ./tests/unit/test-io-channel-tls shows no leakages.
      
      Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
      Signed-off-by: default avatarMatheus Tavares Bernardino <quic_mathbern@quicinc.com>
      Signed-off-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
      c3a2c84a
    • Ross Lagerwall's avatar
      ps2: Don't send key release event for Lang1, Lang2 keys · 92f4a21d
      Ross Lagerwall authored
      
      The scancodes for the Lang1 and Lang2 keys (i.e. Hangeul, Hanja) are
      special since they already have the 0x80 bit set which is commonly used
      to indicate a key release in AT set 1. Reportedly, real hardware does
      not send a key release scancode. So, skip sending a release for these
      keys. This ensures that Windows behaves correctly and interprets it as a
      single keypress rather than two consecutive keypresses.
      
      Signed-off-by: default avatarRoss Lagerwall <ross.lagerwall@citrix.com>
      Signed-off-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
      92f4a21d
    • Willem van de Velde's avatar
      Add qemu qcode support for keys F13 to F24 · ac19b516
      Willem van de Velde authored
      
      To be able to use the function keys F13 to F24 these should be defined in de keycodemapdb and added to the qapi.
      The keycodemapdb is updated in its own repository, this patch enables the use of those keys within qemu.
      
      Signed-off-by: default avatarWillem van de Velde <williamvdvelde@gmail.com>
      Signed-off-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
      ac19b516
  2. Mar 13, 2023
  3. Mar 12, 2023
    • Peter Maydell's avatar
      Merge tag 'linux-user-for-8.0-pull-request' of https://gitlab.com/laurent_vivier/qemu into staging · 29c8a9e3
      Peter Maydell authored
      Pull request linux-user 20230308-v2
      
      Fix gdt on i386/x86_64
      Handle traps on sparc
      Add translation for argument of msync
      Emulate CLONE_PIDFD flag in clone
      handle netlink flag NLA_F_NESTED
      fix sockaddr_in6 endianness
      Fix brk() to release pages
      fill out task state in /proc/self/stat
      add support for xtensa FDPIC
      Fix unaligned memory access in prlimit64 syscall
      add target to host netlink conversions
      fix timerfd read endianness conversion
      Fix access to /proc/self/exe
      Add strace for prlimit64() syscall
      
      # -----BEGIN PGP SIGNATURE-----
      #
      # iQJGBAABCAAwFiEEzS913cjjpNwuT1Fz8ww4vT8vvjwFAmQLqmMSHGxhdXJlbnRA
      # dml2aWVyLmV1AAoJEPMMOL0/L748e+cP/3XYMvPbExNi09idDvgzzBrFFHgnkCnK
      # WAV/laxjHSJkzRNK06jD5KN/G2Osy587GXAWLaN76Y8mYMNJs5x3wwlBrJm0RyeJ
      # mWeETJOjxsFjW1+5LKhYv6fwiDxQcyJUoRKzJI27fYgDS+H+zIpa+uhy82Ah543z
      # i/HPyerp25TWAuVyR6mQICt7cne+4yjhtcjg0GXmnvm2+UVp54FGjesjwpSdbALl
      # OKdCre/JaNOkKoaRSsxm0UhNEyQarJIEf/dv0fTjsEpvNX2SMuLUGCm+n23wjXGN
      # fdnSGkoVe8hHxBtG80Zx8AMfKEmJoVsQw9rSg4HwQKOyrYPnLhHjb8ln43X+f3MN
      # gq9lDBIxH82LH2Q5JqQQe7S2UJycpYb+qj0xm7llH7Wl9VVKG6hRX/Cd7I1PQLEv
      # baPIrtye5TuR6uo0kn6HBB+Hd9RNu2PPHelmEFIGEuNaAPkyOt4FhKFIE/j0BTcg
      # mFVCNj6Os805ks0sjIBvpTU1DBtuqpLxdvvHOwxYKCNThTl70wfHJJEjumfvZ4qT
      # T+me7hRsd+8v1rRjxYGuJn2gqC7JL8miuJCYlZkn2DfMAunmF00U5ULe9KiCJ8V3
      # kDfvO+CdnIN4MSlbtwt+eRSFCmJGGkzZ/jshVxPF3ZVirFu/undphYQnaEZDH+Xd
      # KsPOh8MekMgJ
      # =e55j
      # -----END PGP SIGNATURE-----
      # gpg: Signature made Fri 10 Mar 2023 22:08:35 GMT
      # gpg:                using RSA key CD2F75DDC8E3A4DC2E4F5173F30C38BD3F2FBE3C
      # gpg:                issuer "laurent@vivier.eu"
      # gpg: Good signature from "Laurent Vivier <lvivier@redhat.com>" [full]
      # gpg:                 aka "Laurent Vivier <laurent@vivier.eu>" [full]
      # gpg:                 aka "Laurent Vivier (Red Hat) <lvivier@redhat.com>" [full]
      # Primary key fingerprint: CD2F 75DD C8E3 A4DC 2E4F  5173 F30C 38BD 3F2F BE3C
      
      * tag 'linux-user-for-8.0-pull-request' of https://gitlab.com/laurent_vivier/qemu
      
      : (28 commits)
        linux-user: fix bug about incorrect base addresss of gdt on i386 and x86_64
        linux-user/sparc: Handle tag overflow traps
        linux-user/sparc: Handle floating-point exceptions
        linux-user/sparc: Handle unimplemented flush trap
        linux-user/sparc: Handle coprocessor disabled trap
        linux-user/sparc: Handle privilidged action trap
        linux-user/sparc: Handle priviledged opcode trap
        linux-user/sparc: Handle getcc, setcc, getpsr traps
        linux-user/sparc: Handle division by zero traps
        linux-user/sparc: Handle software breakpoint trap
        linux-user/sparc: Fix sparc64_{get, set}_context traps
        linux-user/sparc: Tidy window spill/fill traps
        linux-user/sparc: Use TT_TRAP for flush windows
        linux-user/sparc: Tidy syscall error return
        linux-user/sparc: Tidy syscall trap
        linux-user: Emulate CLONE_PIDFD flag in clone()
        linux-user: Add translation for argument of msync()
        linux-user: handle netlink flag NLA_F_NESTED
        linux-user: fix sockaddr_in6 endianness
        linux-user: Add strace for prlimit64() syscall
        ...
      
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      29c8a9e3
    • Peter Maydell's avatar
      Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging · 0d622f8b
      Peter Maydell authored
      Block layer patches
      
      - fuse: Fix fallocate(PUNCH_HOLE) to zero out the range
      - qed: remove spurious BDRV_POLL_WHILE()
      
      # -----BEGIN PGP SIGNATURE-----
      #
      # iQJFBAABCAAvFiEE3D3rFZqa+V09dFb+fwmycsiPL9YFAmQLbtURHGt3b2xmQHJl
      # ZGhhdC5jb20ACgkQfwmycsiPL9YekQ//SvVXzKbQCNoKJtbkmx9RYSVZt3C19Nfy
      # +E3vUauBMvO1RA38J+ff3pBp7R2rWu1QQXZCVu0a5bg7R2cYSKs82Ua5Z6SG9KxZ
      # TZSGw2vsYk5pcRJwUS+4lGkvV4zrUsm7gru5h+aL51YS20AaPfSaa/kKKMuWWabm
      # O/7ct/gQdiH+8I3d1WpXTE69ZJoH6WK87TUg9HgdQWPwDgam0gbNEjsGjKioCKIz
      # xuz28v1UufXL2PRIWmPh4X+XSvD81q3adgf+vM5tWOaeAL87Q0eLeyiAI0UrvE64
      # X9IGsiDcbM3PaLSlZPborg/yDatWjnnBimbxAMuT7d4pbZXjbYPBOeLR7zPJQ2qQ
      # x/sFgiAVGiR6pgWIC85E2rIsWfBIEAla/YowZRdNmCO7ar82wBhoGdUQx6nHP18U
      # eJg50EhX9Fhf5kMt3tZf4AaJzn48QsBA+O7PKbc/DZBLrthOLKzyLM6SusbpBG8g
      # jFsdlDYMy9dIB6g3BC6fwZAqQNqbEMlU63ZvQzeq5yPpjFyS5H3IGHLzDiYg/9m6
      # WdRUM/wQKkq0YwF1OumQ+Uu8ClTJPDi/177+hOyQeIFZao3NgznDtA12rNroYOU2
      # pDIff9K9gwOFFNmDDtsjm8h967pF7RJMZylvNilT+7xkMy2kwYdCo76TBYDyN8Kk
      # aYBIDpWtPps=
      # =PUFU
      # -----END PGP SIGNATURE-----
      # gpg: Signature made Fri 10 Mar 2023 17:54:29 GMT
      # gpg:                using RSA key DC3DEB159A9AF95D3D7456FE7F09B272C88F2FD6
      # gpg:                issuer "kwolf@redhat.com"
      # gpg: Good signature from "Kevin Wolf <kwolf@redhat.com>" [full]
      # Primary key fingerprint: DC3D EB15 9A9A F95D 3D74  56FE 7F09 B272 C88F 2FD6
      
      * tag 'for-upstream' of https://repo.or.cz/qemu/kevin
      
      :
        qed: remove spurious BDRV_POLL_WHILE()
        iotests/308: Add test for 'write -zu'
        block/fuse: Let PUNCH_HOLE write zeroes
      
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      0d622f8b
  4. Mar 11, 2023
    • Peter Maydell's avatar
      Merge tag 'pull-gitdm-100323-1' of https://gitlab.com/stsquad/qemu into staging · ee41280a
      Peter Maydell authored
      gitdm updates for:
      
        - IBM
        - Facebook
        - Individual contributors
        - Ventana
      
      # -----BEGIN PGP SIGNATURE-----
      #
      # iQEzBAABCgAdFiEEZoWumedRZ7yvyN81+9DbCVqeKkQFAmQLUy8ACgkQ+9DbCVqe
      # KkRCdwf+L7Y0mHKKvxVyfRO2W51HbzUYqzPF6bFgqxqwbL6CRdPw5Ks3RHGV8N6C
      # Er4MIsVhzLUY7BX+IcHZG1C9/8UrtymY2tUA1Qg5L2NQ/pNvDN9OHA/HXw+JkOq2
      # l/l1ZkWmlT0IZwtTrKYHjZnqxMfEOey33y+t623wtMh7Bpj/ZPjYLsYxhhkwobvc
      # fPFAZ2tukkECFkvylnaoE+3S2g86EY9soZEmeSdOYPtIbeb42o38cTchaAHQnc09
      # sQJ1hguRUpwi1Y1CaP3QCqS8TkdV1oObWJ4+ZfHHXmDWfI0yQfbNFBU7bGZkxGkI
      # i9EKqF+xfdklrqJz9Y7jEjFfetUghA==
      # =p/39
      # -----END PGP SIGNATURE-----
      # gpg: Signature made Fri 10 Mar 2023 15:56:31 GMT
      # gpg:                using RSA key 6685AE99E75167BCAFC8DF35FBD0DB095A9E2A44
      # gpg: Good signature from "Alex Bennée (Master Work Key) <alex.bennee@linaro.org>" [full]
      # Primary key fingerprint: 6685 AE99 E751 67BC AFC8  DF35 FBD0 DB09 5A9E 2A44
      
      * tag 'pull-gitdm-100323-1' of https://gitlab.com/stsquad/qemu
      
      :
        contrib/gitdm: add Idan to IBM's group map
        contrib/gitdm: Add Facebook the domain map
        contrib/gitdm: add Tsukasa as an individual contributor
        contrib/gitdm: Add Ventana Micro Systems to the domain map
        contrib/gitdm: Add VRULL to the domain map
      
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      ee41280a
    • Peter Maydell's avatar
      Merge tag 'net-pull-request' of https://github.com/jasowang/qemu into staging · 7284d53f
      Peter Maydell authored
      # -----BEGIN PGP SIGNATURE-----
      # Version: GnuPG v1
      #
      # iQEcBAABAgAGBQJkCvgFAAoJEO8Ells5jWIRHiUH/jhydpJHIqnAPxHQAwGtmyhb
      # 9Z52UOzW5V6KxfZJ+bQ4RPFkS2UwcxmeadPHY4zvvJTVBLAgG3QVgP4igj8CXKCI
      # xRnwMgTNeu655kZQ5P/elTwdBTCJFODk7Egg/bH3H1ZiUhXBhVRhK7q/wMgtlZkZ
      # Kexo6txCK4d941RNzEh45ZaGhdELE+B+D7cRuQgBs/DXZtJpsyEzBbP8KYSMHuER
      # AXfWo0YIBYj7X3ek9D6j0pbOkB61vqtYd7W6xV4iDrJCcFBIOspJbbBb1tGCHola
      # AXo5/OhRmiQnp/c/HTbJIDbrj0sq/r7LxYK4zY1x7UPbewHS9R+wz+FfqSmoBF0=
      # =056y
      # -----END PGP SIGNATURE-----
      # gpg: Signature made Fri 10 Mar 2023 09:27:33 GMT
      # gpg:                using RSA key EF04965B398D6211
      # gpg: Good signature from "Jason Wang (Jason Wang on RedHat) <jasowang@redhat.com>" [marginal]
      # gpg: WARNING: This key is not certified with sufficiently trusted signatures!
      # gpg:          It is not certain that the signature belongs to the owner.
      # Primary key fingerprint: 215D 46F4 8246 689E C77F  3562 EF04 965B 398D 6211
      
      * tag 'net-pull-request' of https://github.com/jasowang/qemu
      
      : (44 commits)
        ebpf: fix compatibility with libbpf 1.0+
        docs/system/devices/igb: Add igb documentation
        tests/avocado: Add igb test
        igb: Introduce qtest for igb device
        tests/qtest/libqos/e1000e: Export macreg functions
        tests/qtest/e1000e-test: Fabricate ethernet header
        Intrdocue igb device emulation
        e1000: Split header files
        pcie: Introduce pcie_sriov_num_vfs
        net/eth: Introduce EthL4HdrProto
        e1000e: Implement system clock
        net/eth: Report if headers are actually present
        e1000e: Count CRC in Tx statistics
        e1000: Count CRC in Tx statistics
        e1000e: Combine rx traces
        MAINTAINERS: Add e1000e test files
        MAINTAINERS: Add Akihiko Odaki as a e1000e reviewer
        e1000e: Do not assert when MSI-X is disabled later
        hw/net/net_tx_pkt: Check the payload length
        hw/net/net_tx_pkt: Implement TCP segmentation
        ...
      
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      7284d53f
  5. Mar 10, 2023
Loading