Skip to content
Snippets Groups Projects
  1. Jun 23, 2021
    • Thomas Huth's avatar
      ui: Make the DisplayType enum entries conditional · 66c2207f
      Thomas Huth authored
      Libvirt's "domcapabilities" command has a way to state whether certain
      graphic frontends are available in QEMU or not. Originally, libvirt
      looked at the "--help" output of the QEMU binary to determine whether
      SDL was available or not (by looking for the "-sdl" parameter in the
      help text), but since libvirt stopped doing this analysis of the help
      text, the detection of SDL is currently broken, see:
      
       https://bugzilla.redhat.com/show_bug.cgi?id=1790902
      
      
      
      QEMU should provide a way via the QMP interface instead. A simple way,
      without introducing additional commands, is to make the DisplayType
      enum entries conditional, so that the enum only contains the entries if
      the corresponding CONFIG_xxx switches have been set. This of course
      only gives an indication which possibilities have been enabled during
      compile-time of QEMU (and does not take into account whether modules
      are later available or not for example - for this we'd need a separate
      command), but anyway, this should already be good enough for the above
      bug ticket, and it's a good idea anyway to make the QMP interface
      conditional here, so let's simply do it.
      
      Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
      Message-Id: <20210615090439.70926-1-thuth@redhat.com>
      Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
      66c2207f
  2. Jun 15, 2021
  3. Jun 14, 2021
  4. Jun 11, 2021
  5. Jun 04, 2021
    • Paolo Bonzini's avatar
      vl: plug -object back into -readconfig · 49e98769
      Paolo Bonzini authored
      
      Commit bc2f4fcb ("qom: move user_creatable_add_opts logic to vl.c
      and QAPIfy it", 2021-03-19) switched the creation of objects from
      qemu_opts_foreach to a bespoke QTAILQ in preparation for supporting JSON
      syntax in -object.
      
      Unfortunately in doing so it lost support for [object] stanzas in
      configuration files and also for "-set object.ID.KEY=VAL".  The latter
      is hard to re-establish and probably best solved by deprecating -set.
      This patch uses the infrastructure introduced by the previous two
      patches in order to parse QOM objects correctly from configuration
      files.
      
      Cc: Markus Armbruster <armbru@redhat.com>
      Cc: qemu-stable@nongnu.org
      Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Message-Id: <20210524105752.3318299-4-pbonzini@redhat.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      49e98769
    • Paolo Bonzini's avatar
      vl: plumb keyval-based options into -readconfig · c0d4aa82
      Paolo Bonzini authored
      
      Let -readconfig support parsing command line options into QDict or
      QemuOpts.  This will be used to add back support for objects in
      -readconfig.
      
      Cc: Markus Armbruster <armbru@redhat.com>
      Cc: qemu-stable@nongnu.org
      Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Message-Id: <20210524105752.3318299-3-pbonzini@redhat.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      c0d4aa82
    • Paolo Bonzini's avatar
      qemu-config: parse configuration files to a QDict · 37701411
      Paolo Bonzini authored
      
      Change the parser to put the values into a QDict and pass them
      to a callback.  qemu_config_parse's QemuOpts creation is
      itself turned into a callback function.
      
      This is useful for -readconfig to support keyval-based options;
      getting a QDict from the parser removes a roundtrip from
      QDict to QemuOpts and then back to QDict.
      
      Unfortunately there is a disadvantage in that semantic errors will
      point to the last line of the group, because the entries of the QDict
      do not have a location attached.
      
      Cc: Kevin Wolf <kwolf@redhat.com>
      Cc: Markus Armbruster <armbru@redhat.com>
      Cc: qemu-stable@nongnu.org
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Message-Id: <20210524105752.3318299-2-pbonzini@redhat.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      37701411
  6. Jun 02, 2021
  7. May 26, 2021
  8. May 13, 2021
  9. May 12, 2021
  10. May 10, 2021
  11. May 02, 2021
  12. Apr 01, 2021
  13. Mar 24, 2021
  14. Mar 23, 2021
Loading