Skip to content
Snippets Groups Projects
  1. Feb 16, 2022
  2. Feb 15, 2022
    • Peter Maydell's avatar
      Merge remote-tracking branch 'remotes/stefanha-gitlab/tags/block-pull-request' into staging · ad38520b
      Peter Maydell authored
      
      Pull request
      
      This contains coroutine poll size scaling, virtiofsd rseq seccomp for new glibc
      versions, and the QEMU C virtiofsd deprecation notice.
      
      # gpg: Signature made Mon 14 Feb 2022 17:14:21 GMT
      # gpg:                using RSA key 8695A8BFD3F97CDAAC35775A9CA4ABB381AB73C8
      # gpg: Good signature from "Stefan Hajnoczi <stefanha@redhat.com>" [full]
      # gpg:                 aka "Stefan Hajnoczi <stefanha@gmail.com>" [full]
      # Primary key fingerprint: 8695 A8BF D3F9 7CDA AC35  775A 9CA4 ABB3 81AB 73C8
      
      * remotes/stefanha-gitlab/tags/block-pull-request:
        util: adjust coroutine pool size to virtio block queue
        Deprecate C virtiofsd
        tools/virtiofsd: Add rseq syscall to the seccomp allowlist
      
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      ad38520b
    • Peter Maydell's avatar
      Merge remote-tracking branch 'remotes/nvme/tags/nvme-next-pull-request' into staging · cc6721e4
      Peter Maydell authored
      
      hw/nvme updates
      
        - fix CVE-2021-3929
        - add zone random write area support
        - misc cleanups from Philippe
      
      # gpg: Signature made Mon 14 Feb 2022 08:01:34 GMT
      # gpg:                using RSA key 522833AA75E2DCE6A24766C04DE1AF316D4F0DE9
      # gpg: Good signature from "Klaus Jensen <its@irrelevant.dk>" [unknown]
      # gpg:                 aka "Klaus Jensen <k.jensen@samsung.com>" [unknown]
      # gpg: WARNING: This key is not certified with a trusted signature!
      # gpg:          There is no indication that the signature belongs to the owner.
      # Primary key fingerprint: DDCA 4D9C 9EF9 31CC 3468  4272 63D5 6FC5 E55D A838
      #      Subkey fingerprint: 5228 33AA 75E2 DCE6 A247  66C0 4DE1 AF31 6D4F 0DE9
      
      * remotes/nvme/tags/nvme-next-pull-request:
        hw/nvme: add support for zoned random write area
        hw/nvme: add ozcs enum
        hw/nvme: add struct for zone management send
        hw/nvme/ctrl: Pass buffers as 'void *' types
        hw/nvme/ctrl: Have nvme_addr_write() take const buffer
        hw/nvme: fix CVE-2021-3929
      
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      cc6721e4
    • Peter Maydell's avatar
      Merge remote-tracking branch 'remotes/jasowang/tags/net-pull-request' into staging · e56d873f
      Peter Maydell authored
      
      # gpg: Signature made Mon 14 Feb 2022 03:51:14 GMT
      # gpg:                using RSA key EF04965B398D6211
      # gpg: Good signature from "Jason Wang (Jason Wang on RedHat) <jasowang@redhat.com>" [marginal]
      # gpg: WARNING: This key is not certified with sufficiently trusted signatures!
      # gpg:          It is not certain that the signature belongs to the owner.
      # Primary key fingerprint: 215D 46F4 8246 689E C77F  3562 EF04 965B 398D 6211
      
      * remotes/jasowang/tags/net-pull-request:
        net/eth: Don't consider ESP to be an IPv6 option header
        hw/net: e1000e: Clear ICR on read when using non MSI-X interrupts
        net/filter: Optimize filter_send to coroutine
        net/colo-compare.c: Update the default value comments
        net/colo-compare.c: Optimize compare order for performance
        net: Fix uninitialized data usage
        net/tap: Set return code on failure
        hw/net/vmxnet3: Log guest-triggerable errors using LOG_GUEST_ERROR
      
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      e56d873f
  3. Feb 14, 2022
    • Peter Maydell's avatar
      Merge remote-tracking branch 'remotes/kwolf-gitlab/tags/for-upstream' into staging · 2d88a3a5
      Peter Maydell authored
      
      Block layer patches
      
      - Fix crash in blockdev-reopen with iothreads
      - fdc-isa: Respect QOM properties when building AML
      
      # gpg: Signature made Fri 11 Feb 2022 17:44:52 GMT
      # gpg:                using RSA key DC3DEB159A9AF95D3D7456FE7F09B272C88F2FD6
      # gpg:                issuer "kwolf@redhat.com"
      # gpg: Good signature from "Kevin Wolf <kwolf@redhat.com>" [full]
      # Primary key fingerprint: DC3D EB15 9A9A F95D 3D74  56FE 7F09 B272 C88F 2FD6
      
      * remotes/kwolf-gitlab/tags/for-upstream:
        hw/block/fdc-isa: Respect QOM properties when building AML
        iotests: Test blockdev-reopen with iothreads and throttling
        block: Lock AioContext for drain_end in blockdev-reopen
      
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      2d88a3a5
    • Hiroki Narukawa's avatar
      util: adjust coroutine pool size to virtio block queue · 4c41c69e
      Hiroki Narukawa authored
      
      Coroutine pool size was 64 from long ago, and the basis was organized in the commit message in 4d68e86b.
      
      At that time, virtio-blk queue-size and num-queue were not configuable, and equivalent values were 128 and 1.
      
      Coroutine pool size 64 was fine then.
      
      Later queue-size and num-queue got configuable, and default values were increased.
      
      Coroutine pool with size 64 exhausts frequently with random disk IO in new size, and slows down.
      
      This commit adjusts coroutine pool size adaptively with new values.
      
      This commit adds 64 by default, but now coroutine is not only for block devices,
      
      and is not too much burdon comparing with new default.
      
      pool size of 128 * vCPUs.
      
      Signed-off-by: default avatarHiroki Narukawa <hnarukaw@yahoo-corp.jp>
      Message-id: 20220214115302.13294-2-hnarukaw@yahoo-corp.jp
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      4c41c69e
    • Dr. David Alan Gilbert's avatar
      Deprecate C virtiofsd · 34deee7b
      Dr. David Alan Gilbert authored
      
      There's a nice new Rust implementation out there; recommend people
      do new work on that.
      
      Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
      Reviewed-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
      Message-id: 20220210174714.19843-1-dgilbert@redhat.com
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      34deee7b
    • Christian Ehrhardt's avatar
      tools/virtiofsd: Add rseq syscall to the seccomp allowlist · 7b223e38
      Christian Ehrhardt authored
      The virtiofsd currently crashes when used with glibc 2.35.
      That is due to the rseq system call being added to every thread
      creation [1][2].
      
      [1]: https://www.efficios.com/blog/2019/02/08/linux-restartable-sequences/
      [2]: https://sourceware.org/pipermail/libc-alpha/2022-February/136040.html
      
      
      
      This happens not at daemon start, but when a guest connects
      
          /usr/lib/qemu/virtiofsd -f --socket-path=/tmp/testvfsd -o sandbox=chroot \
              -o source=/var/guests/j-virtiofs --socket-group=kvm
          virtio_session_mount: Waiting for vhost-user socket connection...
          # start ok, now guest will connect
          virtio_session_mount: Received vhost-user socket connection
          virtio_loop: Entry
          fv_queue_set_started: qidx=0 started=1
          fv_queue_set_started: qidx=1 started=1
          Bad system call (core dumped)
      
      We have to put rseq on the seccomp allowlist to avoid that the daemon
      is crashing in this case.
      
      Reported-by: default avatarMichael Hudson-Doyle <michael.hudson@canonical.com>
      Signed-off-by: default avatarChristian Ehrhardt <christian.ehrhardt@canonical.com>
      Reviewed-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
      Message-id: 20220209111456.3328420-1-christian.ehrhardt@canonical.com
      
      [Moved rseq to its alphabetically ordered position in the seccomp
      allowlist.
      --Stefan]
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      7b223e38
    • Peter Maydell's avatar
      Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20220211' into staging · 50a75ff6
      Peter Maydell authored
      
      Fix safe_syscall_base for sparc64.
      Fix host signal handling for sparc64-linux.
      Speedups for jump cache and work list probing.
      Fix for exception replays.
      Raise guest SIGBUS for user-only misaligned accesses.
      
      # gpg: Signature made Fri 11 Feb 2022 01:27:16 GMT
      # gpg:                using RSA key 7A481E78868B4DB6A85A05C064DF38E8AF7E215F
      # gpg:                issuer "richard.henderson@linaro.org"
      # gpg: Good signature from "Richard Henderson <richard.henderson@linaro.org>" [full]
      # Primary key fingerprint: 7A48 1E78 868B 4DB6 A85A  05C0 64DF 38E8 AF7E 215F
      
      * remotes/rth-gitlab/tags/pull-tcg-20220211: (34 commits)
        tests/tcg/multiarch: Add sigbus.c
        tcg/sparc: Support unaligned access for user-only
        tcg/sparc: Add tcg_out_jmpl_const for better tail calls
        tcg/sparc: Use the constant pool for 64-bit constants
        tcg/sparc: Convert patch_reloc to return bool
        tcg/sparc: Improve code gen for shifted 32-bit constants
        tcg/sparc: Add scratch argument to tcg_out_movi_int
        tcg/sparc: Split out tcg_out_movi_imm32
        tcg/sparc: Use tcg_out_movi_imm13 in tcg_out_addsub2_i64
        tcg/mips: Support unaligned access for softmmu
        tcg/mips: Support unaligned access for user-only
        tcg/arm: Support raising sigbus for user-only
        tcg/arm: Reserve a register for guest_base
        tcg/arm: Support unaligned access for softmmu
        tcg/arm: Check alignment for ldrd and strd
        tcg/arm: Remove use_armv6_instructions
        tcg/arm: Remove use_armv5t_instructions
        tcg/arm: Drop support for armv4 and armv5 hosts
        tcg/loongarch64: Support raising sigbus for user-only
        tcg/tci: Support raising sigbus for user-only
        ...
      
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      50a75ff6
Loading