Skip to content
Snippets Groups Projects
Select Git revision
  • feature/libtcg-rebase default protected
1 result
Search by author
  • Any Author
  • Anton Anton anjo
1 author
  1. Oct 13, 2020
  3. Oct 12, 2020
    • Paolo Bonzini's avatar
      qom: fix objects with improper parent type · 22fb6eb5
      Paolo Bonzini authored 
      
Some objects accidentally inherit ObjectClass instead of Object.
They compile silently but may crash after downcasting.

In this patch, we introduce a coccinelle script to find broken
declarations and fix them manually with proper base type.

Signed-off-by: default avatarSergey Nizovtsev <snizovtsev@gmail.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      22fb6eb5
    • Paolo Bonzini's avatar
      exec: split out non-softmmu-specific parts · d9f24bf5
      Paolo Bonzini authored 
      
Over the years, most parts of exec.c that were not specific to softmmu
have been moved to accel/tcg; what's left is mostly the low-level part
of the memory API, which includes RAMBlock and AddressSpaceDispatch.
However exec.c also hosts 4-500 lines of code for the target specific
parts of the CPU QOM object, plus a few functions for user-mode
emulation that do not have a better place (they are not TCG-specific so
accel/tcg/user-exec.c is not a good place either).

Move these parts to a new file, so that exec.c can be moved to
softmmu/physmem.c.

Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      d9f24bf5
    • Paolo Bonzini's avatar
      softmmu: move more files to softmmu/ · 800d4ded
      Paolo Bonzini authored 
      
Keep most softmmu_ss files into the system-emulation-specific
directory.

Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      800d4ded
    • Philippe Mathieu-Daudé's avatar
      hw/nvram: Always register FW_CFG_DATA_GENERATOR_INTERFACE · 8d0bceba
      Philippe Mathieu-Daudé authored 
      
While the FW_CFG_DATA_GENERATOR_INTERFACE is only consumed
by a device only available using system-mode (fw_cfg), it is
implemented by a crypto component (tls-cipher-suites) which
is always available when crypto is used.

Commit 69699f30 introduced the following error in the
qemu-storage-daemon binary:

  $ echo -e \
    '{"execute": "qmp_capabilities"}\r\n{"execute": "qom-list-types"}\r\n{"execute": "quit"}\r\n' \
    | storage-daemon/qemu-storage-daemon --chardev stdio,id=qmp0  --monitor qmp0
  {"QMP": {"version": {"qemu": {"micro": 50, "minor": 1, "major": 5}, "package": ""}, "capabilities": ["oob"]}}
  {"return": {}}
  missing interface 'fw_cfg-data-generator' for object 'tls-creds'
  Aborted (core dumped)

Since QOM dependencies are resolved at runtime, this issue
could not be triggered at linktime, and we don't have test
running the qemu-storage-daemon binary.

Fix by always registering the QOM interface.

Reported-by: default avatarKevin Wolf <kwolf@redhat.com>
Fixes: 69699f30 ("crypto/tls-cipher-suites: Produce fw_cfg consumable blob")
Signed-off-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarLaszlo Ersek <lersek@redhat.com>
Reviewed-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
Message-Id: <20201006111909.2302081-2-philmd@redhat.com>
Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      8d0bceba
  5. Oct 06, 2020
  7. Oct 05, 2020
  9. Oct 01, 2020
  11. Sep 30, 2020
  13. Sep 29, 2020
  15. Sep 23, 2020
  17. Sep 14, 2020
  19. Sep 10, 2020
    • Alex Bennée's avatar
      plugins: move the more involved plugins to contrib · c17a386b
      Alex Bennée authored 
      
We have an exploding complexity problem in the testing so lets just
move the more involved plugins into contrib. tests/plugins still exist
for the basic plugins that exercise the API. We restore the old
pre-meson style Makefile for contrib as it also doubles as a guide for
out-of-tree plugin builds.

While we are at it add some examples to the documentation and a
specific plugins build target.

Signed-off-by: default avatarAlex Bennée <alex.bennee@linaro.org>
Message-Id: <20200909112742.25730-11-alex.bennee@linaro.org>
      c17a386b
  21. Sep 09, 2020
  23. Sep 08, 2020
    • Eduardo Habkost's avatar
      codeconverter: script for automating QOM code cleanups · 94dfc0f3
      Eduardo Habkost authored 
      
This started as a simple script that scanned for regular
expressions, but became more and more complex when exceptions to
the rules were found.

I don't know if this should be maintained in the QEMU source tree
long term (maybe it can be reused for other code transformations
that Coccinelle can't handle).  In either case, this is included
as part of the patch series to document how exactly the automated
code transformations in the next patches were done.

Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
Message-Id: <20200831210740.126168-7-ehabkost@redhat.com>
Signed-off-by: default avatarEduardo Habkost <ehabkost@redhat.com>
      94dfc0f3
  25. Sep 07, 2020
    • Thomas Huth's avatar
      gitlab-ci: Add cross-compiling build tests · 6bcb5fc0
      Thomas Huth authored 
      
Now that we can use all our QEMU test containers in the gitlab-CI, we can
easily add some jobs that test cross-compilation for various architectures.
There is just only small ugliness: Since the shared runners on gitlab.com
are single-threaded, we have to split each compilation job into two parts
(--disable-user and --disable-system), and exclude some additional targets,
to avoid that the jobs are running too long and hitting the timeout of 1 h.

Message-Id: <20200823111757.72002-8-thuth@redhat.com>
Reviewed-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
      6bcb5fc0
  27. Sep 02, 2020
  29. Sep 01, 2020
  31. Aug 24, 2020
  33. Jul 27, 2020
  35. Jul 21, 2020
  37. Jul 20, 2020
  39. Jul 17, 2020
  41. Jul 14, 2020