Skip to content
Snippets Groups Projects
  • Stefan Hajnoczi's avatar
    60f782b6
    aio: remove aio_disable_external() API · 60f782b6
    Stefan Hajnoczi authored
    All callers now pass is_external=false to aio_set_fd_handler() and
    aio_set_event_notifier(). The aio_disable_external() API that
    temporarily disables fd handlers that were registered is_external=true
    is therefore dead code.
    
    Remove aio_disable_external(), aio_enable_external(), and the
    is_external arguments to aio_set_fd_handler() and
    aio_set_event_notifier().
    
    The entire test-fdmon-epoll test is removed because its sole purpose was
    testing aio_disable_external().
    
    Parts of this patch were generated using the following coccinelle
    (https://coccinelle.lip6.fr/
    
    ) semantic patch:
    
      @@
      expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque;
      @@
      - aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque)
      + aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque)
    
      @@
      expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready;
      @@
      - aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready)
      + aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready)
    
    Reviewed-by: default avatarJuan Quintela <quintela@redhat.com>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Message-Id: <20230516190238.8401-21-stefanha@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    60f782b6
    History
    aio: remove aio_disable_external() API
    Stefan Hajnoczi authored
    All callers now pass is_external=false to aio_set_fd_handler() and
    aio_set_event_notifier(). The aio_disable_external() API that
    temporarily disables fd handlers that were registered is_external=true
    is therefore dead code.
    
    Remove aio_disable_external(), aio_enable_external(), and the
    is_external arguments to aio_set_fd_handler() and
    aio_set_event_notifier().
    
    The entire test-fdmon-epoll test is removed because its sole purpose was
    testing aio_disable_external().
    
    Parts of this patch were generated using the following coccinelle
    (https://coccinelle.lip6.fr/
    
    ) semantic patch:
    
      @@
      expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque;
      @@
      - aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque)
      + aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque)
    
      @@
      expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready;
      @@
      - aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready)
      + aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready)
    
    Reviewed-by: default avatarJuan Quintela <quintela@redhat.com>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@linaro.org>
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Message-Id: <20230516190238.8401-21-stefanha@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>