aio: remove aio_disable_external() API
All callers now pass is_external=false to aio_set_fd_handler() and aio_set_event_notifier(). The aio_disable_external() API that temporarily disables fd handlers that were registered is_external=true is therefore dead code. Remove aio_disable_external(), aio_enable_external(), and the is_external arguments to aio_set_fd_handler() and aio_set_event_notifier(). The entire test-fdmon-epoll test is removed because its sole purpose was testing aio_disable_external(). Parts of this patch were generated using the following coccinelle (https://coccinelle.lip6.fr/ ) semantic patch: @@ expression ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque; @@ - aio_set_fd_handler(ctx, fd, is_external, io_read, io_write, io_poll, io_poll_ready, opaque) + aio_set_fd_handler(ctx, fd, io_read, io_write, io_poll, io_poll_ready, opaque) @@ expression ctx, notifier, is_external, io_read, io_poll, io_poll_ready; @@ - aio_set_event_notifier(ctx, notifier, is_external, io_read, io_poll, io_poll_ready) + aio_set_event_notifier(ctx, notifier, io_read, io_poll, io_poll_ready) Reviewed-by:Juan Quintela <quintela@redhat.com> Reviewed-by:
Philippe Mathieu-Daudé <philmd@linaro.org> Signed-off-by:
Stefan Hajnoczi <stefanha@redhat.com> Message-Id: <20230516190238.8401-21-stefanha@redhat.com> Signed-off-by:
Kevin Wolf <kwolf@redhat.com>
Showing
- block.c 0 additions, 7 deletionsblock.c
- block/blkio.c 5 additions, 10 deletionsblock/blkio.c
- block/curl.c 5 additions, 5 deletionsblock/curl.c
- block/export/fuse.c 4 additions, 4 deletionsblock/export/fuse.c
- block/export/vduse-blk.c 5 additions, 5 deletionsblock/export/vduse-blk.c
- block/io.c 0 additions, 2 deletionsblock/io.c
- block/io_uring.c 2 additions, 2 deletionsblock/io_uring.c
- block/iscsi.c 1 addition, 2 deletionsblock/iscsi.c
- block/linux-aio.c 2 additions, 2 deletionsblock/linux-aio.c
- block/nfs.c 2 additions, 3 deletionsblock/nfs.c
- block/nvme.c 4 additions, 4 deletionsblock/nvme.c
- block/ssh.c 2 additions, 2 deletionsblock/ssh.c
- block/win32-aio.c 3 additions, 3 deletionsblock/win32-aio.c
- hw/i386/kvm/xen_xenstore.c 1 addition, 1 deletionhw/i386/kvm/xen_xenstore.c
- hw/virtio/virtio.c 3 additions, 3 deletionshw/virtio/virtio.c
- hw/xen/xen-bus.c 4 additions, 4 deletionshw/xen/xen-bus.c
- include/block/aio.h 0 additions, 57 deletionsinclude/block/aio.h
- io/channel-command.c 2 additions, 4 deletionsio/channel-command.c
- io/channel-file.c 1 addition, 2 deletionsio/channel-file.c
- io/channel-socket.c 1 addition, 2 deletionsio/channel-socket.c
Loading
Please register or sign in to comment