Skip to content
Snippets Groups Projects
Alessandro Di Federico's avatar
closed merge request !4 "`master` promotion" at revng / orchestra
Alessandro Di Federico's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

Sounds like a good plan....

Giacomo Vercesi's avatar
joined project revng / orchestra
Giacomo Vercesi's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

Implemented and pushed, it's in the orchestra repo

Giacomo Vercesi's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

ACK, leaving this message here on (IMHO) how to handle the transition:...

Alessandro Di Federico's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

I can add another env variable which skips cleanup...

Alessandro Di Federico's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

Uhm, OK.

Giacomo Vercesi's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

Eh ok, I can move this file there....

Giacomo Vercesi's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

I'd move this to something like .orchestra/ci/cleanup.sh which is then called after the call to .orchestra/ci/ci.sh. I think this is better because...

Alessandro Di Federico's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

You're right, it's not a perfect solution....

Giacomo Vercesi's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

I did look at that, and considered it with master. But then the behavior would be "different" from all the other orchestra stuff, e.g. it would not...

Alessandro Di Federico's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

This list will break and go unnoticed....

Alessandro Di Federico's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

In the past we considered this: https://docs.gitlab.com/ee/ci/pipelines/settings.html#specify-a-custom-cicd-configuration-file...

Giacomo Vercesi's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

As we discussed, test_pipeline_id is no longer needed since the only time the hitman CI is triggered is after the regression suite has run.

Giacomo Vercesi's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

Done

Giacomo Vercesi's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

Done

Giacomo Vercesi's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

Checked, there's no way to specify a .gitlab-ci.yml from the orchestra repo

Giacomo Vercesi's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

I've double checked, the pipeline_create function relies on the list of changed files in the binary archives, so to make it all work it would requi...

Alessandro Di Federico's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

Add a comment stating why we forward this stuff.

Alessandro Di Federico's avatar
commented on merge request !4 "`master` promotion" at revng / orchestra

Can we launch the CI with a custom .gitlab-ci.yml file so that we can move this to the real orchestra?