- Oct 03, 2018
-
-
Alessandro Di Federico authored
This commit also fixes a bug due to some problem in how we were building the self-referencing metadata associated to `alias.scope`.
-
Alessandro Di Federico authored
`InlineAsm` instructions resemble function calls. You also have to provide the prototype of the called function. Before this commit, we were employing `void(void)`, which was wrong since we were passing in a CSV. In this commit we add a pointer argument to this prototype, which prevents an assertion in LLVM from being triggered.
-
Alessandro Di Federico authored
In stack analysis' output, the list of basic blocks composing a function was not sorted. This lead a test to fail due to the presence of the `--order` flag when comparing the output. This commit ensures that this list is ordered, by basic block name.
-
Alessandro Di Federico authored
Update an assertion trying to enforce the fact that `alloca`s copied from `root` where in the original entry block, while they should be in the `dummy` entry block. Additionally, an improvement has been introduced which ensures only one `alloca` is copied per-function, while, before, we were creating a new `alloca` for each use in that function.
-
Alessandro Di Federico authored
This commit dismisses the `argparse` library (the only non-runtime C component of rev.ng) in favor of LLVM's CommandLine library, which offers several benefits. Among others, now command line arguments can be easily specified as a global variable, decentralizing their management and avoiding the long list of arguments in the constructor of singleton objects such as `CodeGenerator`.
-
Alessandro Di Federico authored
This commit introduces `revng_log`, a macro analagous to `revng_assert`, which basically allows to have the benefit of the `Logger` class without having to compute the expression to log if the logger is disabled. This commit also completely dismisses the `DBG` macro, converting all the old code to `Logger` + `revng_log`.
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
In `support.c`, we employ `arch_prctl` to set the value of segment registers. However glibc, despite providing that function, doesn't provide its prototype in any header file. This commit declares it, according to the declaration provided in the man page.
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
This commit moves around most files. The new directory structure is as follows: * `lib/$LIBRARY/`: contains a library, i.e., a set of `.cpp` files used by multiple libraries/tools. * `include/revng/$LIBRARY/`: contains the public headers associated to the library in `lib/$LIBRARY/`. * `tools/$TOOL/`: directory where all the `.cpp` files (and private headers) for a tool reside. Currently we have two tools: `revamb` and `revamb-dump`. On top of this, all file names are now in camel case.
-
- Sep 29, 2018
-
-
Alessandro Di Federico authored
This commit checks if valgrind headers are available and, if so, defines a macro. In this way, if the heders are not available, `valgrindhelper.h` can be aware of this fact and become a no-op.
-
Alessandro Di Federico authored
Many of the previous commits are aimed at suppressing several compiler warnings. This commit updates the set of warning we want to have.
-
Alessandro Di Federico authored
`FunctionPass` has a static field `ID`. In templated passes, this needs to be declared in the header file and defined in a `.cpp` file. This does this, the right way.
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
This commit suppresses a warning due to the fact that an instance of `std::integral_context` embedding `dlclose` was missing the `noexcept` specifier in the type, due to a `decltype` limitation.
-
Alessandro Di Federico authored
This commit introduces a trick for having optional arguments in macros. This enables the `revng_abort` and `revng_unreachable` macros to have 0 or 1 argument, and the `revng_assert` and `revng_check` macros to have 1 or 2 arguments. Note that, by employing a macro trick (instead of C++ default arguments), we keep the header compatible with C files.
-
Alessandro Di Federico authored
The macro invoking ``__builtin_assume` was using the expression passed by the user to the builtin directly. This commit introduces an explicit cast to `bool`, which is sometimes required.
-
Alessandro Di Federico authored
`clang-format` tends to make fit as much content as possible within a line, even splitting string literals. However, this is not legal for `_Pragma` expressions. This commit disables `clang-format` in the portion of code using `_Pragma`.
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
This commit enforces, through `scripts/check-conventions.sh`, the absence of `assert(false)` and direct calls to `assert`, `abort` and `llvm_unreachable`.
-
Alessandro Di Federico authored
Certain non-`static` functions were missing prototype declarations, triggering a compiler warning. This was due to a missing header or due to a bug in boost. This commit resolves this situation.
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
We'd switch to C++17, but we currently aim at supporting building revamb with Ubuntu 16.04, whose default version of GCC doesn't support C++17.
-
Alessandro Di Federico authored
This commit enforces on the whole project the usage of our own assertion system. This means all calls to `abort`, `assert` and `llvm_unreachable` have been replaced with calls to `revng_abort`, `revng_assert` and `revng_unreachable`, respectively. The error messages, usually expressed as `assert(Condition && "Message")` have now been replaced using the second (optional) argument of `revng_assert`. Additionally, all the `assert(false)` statements have been replaced with calls to `revng_abort`. Apart from readibility, this ensures the compilers is aware of the fact that call will never return. This change will enable us to drop many statements whose sole purpose was marking a variable employed in an assertion as used in release mode. In fact, with the new assertion system this is no longer necessary.
-
- Sep 26, 2018
-
-
Alessandro Di Federico authored
We used to have a `_` prefix for include guards macros, however, according to the standard, macros starting with an underscore are reserved. This commit drops them all.
-
- Sep 21, 2018
-
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
This commit applies our `clang-format` rules globally. From now on, all commits should respect our configuration file. Pretty large change.
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
Include directives are groups by library, the groups should be sorted from the most general (i.e., the STL) to the most specific (the local includes). This commit ensures that Boost includes are before LLVM includes.
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
This commit introduces `using` statements and `constexpr` functions to increase readibility of various types.
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
-
Alessandro Di Federico authored
Sometimes the true-branch of an `if` statement was using braces but the false-branch was not. This commit fixes this.
-