Merge pull request #7 from matthewpurcell/master

Added option for full screen login

README.md

@@ -3,7 +3,7 @@
 A Discourse Plugin to enable authentication via SAML
 
 Setting up your idp:
-The entitiy-id should be: http://example.com
+The entity-id should be: http://example.com
 The consumer assertion service url should be: https://example.com/auth/saml/callback
 
 You may need to set your idp to send an extra custom attribute 'screenName', that will become the users id.
@@ -21,11 +21,14 @@ Add the following settings to your `app.yml` file in the Environment Settings se
   DISCOURSE_SAML_TARGET_URL: https://idpvendor.com/saml/login/
   DISCOURSE_SAML_CERT_FINGERPRINT: "43:BB:DA:FF..."
   #DISCOURSE_SAML_REQUEST_METHOD: post
+  #DISCOURSE_SAML_FULL_SCREEN_LOGIN: true
   DISCOURSE_SAML_CERT: "-----BEGIN CERTIFICATE----- 
   ...
   -----END CERTIFICATE-----"
 ```
 
+The `DISCOURSE_FULL_SCREEN_LOGIN` option allows the SSO login page to be presented within the main browser window, rather than a popup. If SAML is your only authentication method this can look neater, as when the user clicks the Log In button the login page will follow through within the main browser window rather than opening a pop-up. This setting is commented out by default - if you want full screen login uncomment that line and set the value to true (as per the example above).
+
 For non docker:
 
 Add the following settings to your `discourse.conf` file:

plugin.rb

@@ -151,4 +151,5 @@ auth_provider :title => button_title,
               :frame_width => 600,
               :frame_height => 380,
               :background_color => '#003366',
+              :full_screen_login => GlobalSetting.try(:saml_full_screen_login) || false,
               :custom_url => request_method == 'post' ? "/discourse_saml" : nil