Markus Armbruster
authored
Recent commit 69520261 "monitor: Tidy up find_device_state()" assumed the function's argument is "the device's ID or QOM path" (as documented for device_del). It's actually either an absolute QOM path, or a QOM path relative to /machine/peripheral/. Such a relative path is a device ID when it doesn't contain a slash. When it does, the function now always fails. Broke iotest 200, which uses relative path "vda/virtio-backend". It fails because object_resolve_path_component() resolves just one component, not a relative path. The obvious function to resolve relative paths is object_resolve_path(). It picks a parent automatically. Too much magic, we want to specify the parent. Create new object_resolve_path_at() for that, and use it in find_device_state(). Reported-by:Christian Borntraeger <borntraeger@de.ibm.com> Signed-off-by:
Markus Armbruster <armbru@redhat.com> Message-Id: <20211019085711.86377-1-armbru@redhat.com> Tested-by:
Christian Borntraeger <borntraeger@de.ibm.com> Acked-by:
Paolo Bonzini <pbonzini@redhat.com>
Name | Last commit | Last update |
---|---|---|
.. | ||
container.c | ||
meson.build | ||
object.c | ||
object_interfaces.c | ||
qom-hmp-cmds.c | ||
qom-qmp-cmds.c | ||
qom-qobject.c | ||
trace-events | ||
trace.h |