Skip to content
Snippets Groups Projects
  1. Apr 07, 2009
  2. Apr 05, 2009
  3. Mar 28, 2009
  4. Mar 20, 2009
  5. Mar 12, 2009
  6. Mar 05, 2009
  7. Mar 03, 2009
    • Anthony Liguori's avatar
      Fix CVE-2008-0928 - insufficient block device address range checking (Anthony Liguori) · 71d0770c
      Anthony Liguori authored
      
      Introduce a growable flag that's set by bdrv_file_open().  Block devices should
      never be growable, only files that are being used by block devices.
      
      I went through Fabrice's early comments about the patch that was first applied.
      While I disagree with that patch, I also disagree with Fabrice's suggestion.
      
      There's no good reason to do the checks in the block drivers themselves.  It
      just increases the possibility that this bug could show up again.  Since we're
      calling bdrv_getlength() to determine the length, we're giving the block drivers
      a chance to chime in and let us know what range is valid.
      
      Basically, this patch makes the BlockDriver API guarantee that all requests are
      within 0..bdrv_getlength() which to me seems like a Good Thing.
      
      What do others think?
      
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
      
      
      git-svn-id: svn://svn.savannah.nongnu.org/qemu/trunk@6677 c046a42c-6fe2-441c-8c8c-71466251a162
      71d0770c
  8. Feb 11, 2009
  9. Nov 08, 2008
  10. Sep 17, 2008
  11. Mar 11, 2008
  12. Dec 24, 2007
  13. Dec 02, 2007
  14. Nov 11, 2007
  15. Sep 17, 2007
  16. Sep 16, 2007
  17. Aug 19, 2006
  18. Aug 07, 2006
  19. Aug 06, 2006
  20. Aug 05, 2006
  21. Aug 01, 2006
  22. Jun 04, 2006
  23. Dec 18, 2005
  24. Nov 16, 2004
  25. Sep 18, 2004
  26. Aug 01, 2004
Loading