Skip to content
Snippets Groups Projects
  1. Oct 13, 2020
  2. Aug 21, 2020
  3. Jul 30, 2019
    • Kevin Wolf's avatar
      tests/multiboot: Fix load address of test kernels · 6078a0b6
      Kevin Wolf authored
      
      While older toolchains produced binaries where the physical load address
      of ELF segments was the same as the virtual address, newer versions seem
      to choose a different physical address if it isn't specified explicitly.
      The means that the test kernel doesn't use the right addresses to access
      e.g. format strings any more and the whole output disappears, causing
      all test cases to fail.
      
      Fix this by specifying the physical load address of sections explicitly.
      
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
      6078a0b6
  4. Mar 08, 2019
  5. Mar 21, 2018
  6. Aug 11, 2017
    • Eric Blake's avatar
      tests/multiboot: Fix whitespace failure · 01a02ec4
      Eric Blake authored
      
      Commit b43671f8 accidentally broke run_test.sh within tests/multiboot;
      due to a subtle change in whitespace.
      
      These two commands produce theh same output (at least, for sane $IFS
      of space-tab-newline):
      
      echo -e "...$@..."
      echo -e "...$*..."
      
      But that's only because echo inserts spaces between multiple arguments
      (the $@ case), while the $* form gives a single argument to echo with
      the spaces already present.
      
      But when converting to printf %b, there are no automatic spaces between
      multiple arguments, so we HAVE to use $*.
      
      It doesn't help that run_test.sh isn't part of 'make check'.
      
      Signed-off-by: default avatarEric Blake <eblake@redhat.com>
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
      01a02ec4
  7. Jul 11, 2017
    • Eric Blake's avatar
      tests: Avoid non-portable 'echo -ARG' · b43671f8
      Eric Blake authored
      
      POSIX says that backslashes in the arguments to 'echo', as well as
      any use of 'echo -n' and 'echo -e', are non-portable; it recommends
      people should favor 'printf' instead.  This is definitely true where
      we do not control which shell is running (such as in makefile snippets
      or in documentation examples).  But even for scripts where we
      require bash (and therefore, where echo does what we want by default),
      it is still possible to use 'shopt -s xpg_echo' to change bash's
      behavior of echo.  And setting a good example never hurts when we are
      not sure if a snippet will be copied from a bash-only script to a
      general shell script (although I don't change the use of non-portable
      \e for ESC when we know the running shell is bash).
      
      Replace 'echo -n "..."' with 'printf %s "..."', and 'echo -e "..."'
      with 'printf %b "...\n"', with the optimization that the %s/%b
      argument can be omitted if the string being printed is a strict
      literal with no '%', '$', or '`' (we could technically also make
      this optimization when there are $ or `` substitutions but where
      we can prove their results will not be problematic, but proving
      that such substitutions are safe makes the patch less trivial
      compared to just being consistent).
      
      In the qemu-iotests check script, fix unusual shell quoting
      that would result in word-splitting if 'date' outputs a space.
      
      In test 051, take an opportunity to shorten the line.
      
      In test 068, get rid of a pointless second invocation of bash.
      
      CC: qemu-trivial@nongnu.org
      Signed-off-by: default avatarEric Blake <eblake@redhat.com>
      Message-id: 20170703180950.9895-1-eblake@redhat.com
      Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
      b43671f8
  8. Jan 26, 2015
  9. Oct 28, 2013
    • Kevin Wolf's avatar
      tests: Multiboot mmap test case · d1f3a23b
      Kevin Wolf authored
      
      This adds a test case for Multiboot memory map in the tests/multiboot
      directory, where future i386 test kernels can be dropped. Because this
      requires an x86 build host and an installed 32 bit libgcc, the test is
      not part of a regular 'make check'.
      
      The reference output for the test is verified against test runs of the
      same multiboot kernel booted by some GRUB 0.97.
      
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
      d1f3a23b
Loading