Skip to content
Snippets Groups Projects
  1. Oct 06, 2023
  2. Jun 01, 2023
  3. Mar 22, 2022
  4. Jul 12, 2021
  5. Mar 06, 2021
    • Paolo Bonzini's avatar
      trace: fix "-trace file=..." · 9f45a641
      Paolo Bonzini authored
      
      Because trace_opt_parse always deletes the options it has parsed,
      trace_init_file's call to qemu_find_opts_singleton always
      creates an empty -trace option group.  Therefore, the subsequent
      qemu_opt_get(opts, "file") always returns NULL.
      
      To fix this, save the last "-trace file=..." option in a global
      variable and use it later in trace_init_file.
      
      This is similar to what was done before commit 92eecfff ("trace:
      remove argument from trace_init_file", 2020-11-11), except contained
      within trace/control.c and without memory leaks.
      
      Fixes: 92eecfff ("trace: remove argument from trace_init_file", 2020-11-11)
      Cc: stefanha@redhat.com
      Reported-by: default avatar <armbru@redhat.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      Message-Id: <20210209145759.141231-2-pbonzini@redhat.com>
      9f45a641
  6. Jan 04, 2021
  7. Nov 11, 2020
  8. Oct 26, 2020
    • Josh DuBois's avatar
      trace/simple: Enable tracing on startup only if the user specifies a trace option · 648b4823
      Josh DuBois authored
      
      Tracing can be enabled at the command line or via the
      monitor. Command-line trace options are recorded during
      trace_opt_parse(), but tracing is not enabled until the various
      front-ends later call trace_init_file(). If the user passes a trace
      option on the command-line, remember that and enable tracing during
      trace_init_file().  Otherwise, trace_init_file() should record the
      trace file specified by the frontend and avoid enabling traces
      until the user requests them via the monitor.
      
      This fixes 1b7157be and also
      db25d56c, by allowing the user
      to enable traces on the command line and also avoiding
      unwanted trace-<pid> files when the user has not asked for them.
      
      Fixes: 1b7157be
      Signed-off-by: default avatarJosh DuBois <josh@joshdubois.com>
      Message-id: 20200816174610.20253-1-josh@joshdubois.com
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      648b4823
  9. Oct 09, 2020
  10. Aug 21, 2020
    • Paolo Bonzini's avatar
      trace: switch position of headers to what Meson requires · 243af022
      Paolo Bonzini authored
      
      Meson doesn't enjoy the same flexibility we have with Make in choosing
      the include path.  In particular the tracing headers are using
      $(build_root)/$(<D).
      
      In order to keep the include directives unchanged,
      the simplest solution is to generate headers with patterns like
      "trace/trace-audio.h" and place forwarding headers in the source tree
      such that for example "audio/trace.h" includes "trace/trace-audio.h".
      
      This patch is too ugly to be applied to the Makefiles now.  It's only
      a way to separate the changes to the tracing header files from the
      Meson rewrite of the tracing logic.
      
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      243af022
  11. Jul 29, 2020
  12. Feb 25, 2020
  13. Jan 30, 2020
  14. Dec 19, 2019
  15. Aug 27, 2019
    • Philippe Mathieu-Daudé's avatar
      trace: Clarify DTrace/SystemTap help message · 9f591a5d
      Philippe Mathieu-Daudé authored
      
      Most tracing backends are implemented within QEMU, except the
      DTrace/SystemTap backends.
      
      One side effect is when running 'qemu -trace help', an incomplete
      list of trace events is displayed when using the DTrace/SystemTap
      backends.
      
      This is partly due to trace events registered as modules with
      trace_init(), and since the events are not used within QEMU,
      the linker optimize and remove the unused modules (which is
      OK in this particular case).
      Currently only the events compiled in trace-root.o and in the
      last trace.o member of libqemuutil.a are linked, resulting in
      an incomplete list of events.
      
      To avoid confusion, improve the help message, recommending to
      use the proper systemtap script to display the events list.
      
      Before:
      
        $ lm32-softmmu/qemu-system-lm32 -trace help 2>&1 | wc -l
        70
      
      After:
      
        $ lm32-softmmu/qemu-system-lm32 -trace help
        Run 'qemu-trace-stap list qemu-system-lm32' to print a list
        of names of trace points with the DTrace/SystemTap backends.
      
        $ qemu-trace-stap list qemu-system-lm32 | wc -l
        1136
      
      Signed-off-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
      Message-id: 20190823142203.5210-1-philmd@redhat.com
      Message-Id: <20190823142203.5210-1-philmd@redhat.com>
      Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      9f591a5d
  16. Jul 19, 2018
  17. Feb 09, 2018
  18. Sep 19, 2017
    • Alistair Francis's avatar
      Convert remaining error_report() to warn_report() · 55d527a9
      Alistair Francis authored
      
      In a previous patch (3dc6f869) we
      converted uses of error_report("warning:"... to use warn_report()
      instead. This was to help standardise on a single method of printing
      warnings to the user.
      
      There appears to have been some cases that slipped through in patch sets
      applied around the same time, this patch catches the few remaining
      cases.
      
      All of the warnings were changed using this command:
        find ./* -type f -exec sed -i \
          's|error_report(".*warning[,:] |warn_report("|Ig' {} +
      
      Indentation fixed up manually afterwards.
      
      Two messages were manually fixed up as well.
      
      Signed-off-by: default avatarAlistair Francis <alistair.francis@xilinx.com>
      Cc: Kevin Wolf <kwolf@redhat.com>
      Cc: Max Reitz <mreitz@redhat.com>
      Cc: Christian Borntraeger <borntraeger@de.ibm.com>
      Cc: Cornelia Huck <cohuck@redhat.com>
      Cc: Alexander Graf <agraf@suse.de>
      Cc: Richard Henderson <rth@twiddle.net>
      Cc: Stefan Hajnoczi <stefanha@redhat.com>
      Acked-by: default avatarCornelia Huck <cohuck@redhat.com>
      Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
      Message-Id: <eec8cba0d5434bd828639e5e45f12182490ff47d.1505158760.git.alistair.francis@xilinx.com>
      Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
      55d527a9
  19. Jul 17, 2017
  20. Jul 13, 2017
    • Alistair Francis's avatar
      Convert error_report() to warn_report() · 3dc6f869
      Alistair Francis authored
      
      Convert all uses of error_report("warning:"... to use warn_report()
      instead. This helps standardise on a single method of printing warnings
      to the user.
      
      All of the warnings were changed using these two commands:
          find ./* -type f -exec sed -i \
            's|error_report(".*warning[,:] |warn_report("|Ig' {} +
      
      Indentation fixed up manually afterwards.
      
      The test-qdev-global-props test case was manually updated to ensure that
      this patch passes make check (as the test cases are case sensitive).
      
      Signed-off-by: default avatarAlistair Francis <alistair.francis@xilinx.com>
      Suggested-by: default avatarThomas Huth <thuth@redhat.com>
      Cc: Jeff Cody <jcody@redhat.com>
      Cc: Kevin Wolf <kwolf@redhat.com>
      Cc: Max Reitz <mreitz@redhat.com>
      Cc: Ronnie Sahlberg <ronniesahlberg@gmail.com>
      Cc: Paolo Bonzini <pbonzini@redhat.com>
      Cc: Peter Lieven <pl@kamp.de>
      Cc: Josh Durgin <jdurgin@redhat.com>
      Cc: "Richard W.M. Jones" <rjones@redhat.com>
      Cc: Markus Armbruster <armbru@redhat.com>
      Cc: Peter Crosthwaite <crosthwaite.peter@gmail.com>
      Cc: Richard Henderson <rth@twiddle.net>
      Cc: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
      Cc: Greg Kurz <groug@kaod.org>
      Cc: Rob Herring <robh@kernel.org>
      Cc: Peter Maydell <peter.maydell@linaro.org>
      Cc: Peter Chubb <peter.chubb@nicta.com.au>
      Cc: Eduardo Habkost <ehabkost@redhat.com>
      Cc: Marcel Apfelbaum <marcel@redhat.com>
      Cc: "Michael S. Tsirkin" <mst@redhat.com>
      Cc: Igor Mammedov <imammedo@redhat.com>
      Cc: David Gibson <david@gibson.dropbear.id.au>
      Cc: Alexander Graf <agraf@suse.de>
      Cc: Gerd Hoffmann <kraxel@redhat.com>
      Cc: Jason Wang <jasowang@redhat.com>
      Cc: Marcelo Tosatti <mtosatti@redhat.com>
      Cc: Christian Borntraeger <borntraeger@de.ibm.com>
      Cc: Cornelia Huck <cohuck@redhat.com>
      Cc: Stefan Hajnoczi <stefanha@redhat.com>
      Acked-by: default avatarDavid Gibson <david@gibson.dropbear.id.au>
      Acked-by: default avatarGreg Kurz <groug@kaod.org>
      Acked-by: default avatarCornelia Huck <cohuck@redhat.com>
      Reviewed-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
      Reviewed by: Peter Chubb <peter.chubb@data61.csiro.au>
      Acked-by: default avatarMax Reitz <mreitz@redhat.com>
      Acked-by: default avatarMarcel Apfelbaum <marcel@redhat.com>
      Message-Id: <e1cfa2cd47087c248dd24caca9c33d9af0c499b0.1499866456.git.alistair.francis@xilinx.com>
      Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
      Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
      3dc6f869
  21. Jan 31, 2017
  22. Jan 16, 2017
  23. Oct 12, 2016
  24. Sep 28, 2016
  25. Sep 05, 2016
  26. Jul 18, 2016
Loading