Skip to content
Snippets Groups Projects
  1. Sep 07, 2020
  2. May 18, 2020
    • Hanna Reitz's avatar
      block: Use bdrv_default_perms() · 69dca43d
      Hanna Reitz authored
      
      bdrv_default_perms() can decide which permission profile to use based on
      the BdrvChildRole, so block drivers do not need to select it explicitly.
      
      The blkverify driver now no longer shares the WRITE permission for the
      image to verify.  We thus have to adjust two places in
      test-block-iothread not to take it.  (Note that in theory, blkverify
      should behave like quorum in this regard and share neither WRITE nor
      RESIZE for both of its children.  In practice, it does not really
      matter, because blkverify is used only for debugging, so we might as
      well keep its permissions rather liberal.)
      
      Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
      Reviewed-by: default avatarEric Blake <eblake@redhat.com>
      Message-Id: <20200513110544.176672-30-mreitz@redhat.com>
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
      69dca43d
    • Hanna Reitz's avatar
      block: Make filter drivers use child_of_bds · b3af2af4
      Hanna Reitz authored
      
      Note that some filters have secondary children, namely blkverify (the
      image to be verified) and blklogwrites (the log).  This patch does not
      touch those children.
      
      Note that for blkverify, the filtered child should not be format-probed.
      While there is nothing enforcing this here, in practice, it will not be:
      blkverify implements .bdrv_file_open.  The block layer ensures (and in
      fact, asserts) that BDRV_O_PROTOCOL is set for every BDS whose driver
      implements .bdrv_file_open.  This flag will then be bequeathed to
      blkverify's children, and they will thus (by default) not be probed
      either.
      
      ("By default" refers to the fact that blkverify's other child (the
      non-filtered one) will have BDRV_O_PROTOCOL force-unset, because that is
      what happens for all non-filtered children of non-format drivers.)
      
      Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
      Message-Id: <20200513110544.176672-27-mreitz@redhat.com>
      Reviewed-by: default avatarEric Blake <eblake@redhat.com>
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
      b3af2af4
    • Hanna Reitz's avatar
      block: Add BdrvChildRole to BdrvChild · 258b7765
      Hanna Reitz authored
      
      For now, it is always set to 0.  Later patches in this series will
      ensure that all callers pass an appropriate combination of flags.
      
      Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
      Reviewed-by: default avatarEric Blake <eblake@redhat.com>
      Message-Id: <20200513110544.176672-6-mreitz@redhat.com>
      Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
      258b7765
  3. Feb 18, 2020
  4. Jan 06, 2020
Loading