Skip to content
Snippets Groups Projects
  1. Aug 21, 2020
  2. Aug 19, 2020
    • Peter Maydell's avatar
      Merge remote-tracking branch 'remotes/maxreitz/tags/pull-block-2020-08-11' into staging · 1d806cef
      Peter Maydell authored
      
      Block patches for 5.1.0-rc4:
      - Fix abort when running a backup job on an image whose size is not
        aligned to the backup job's cluster size
      
      # gpg: Signature made Tue 11 Aug 2020 10:29:27 BST
      # gpg:                using RSA key 91BEB60A30DB3E8857D11829F407DB0061D5CF40
      # gpg:                issuer "mreitz@redhat.com"
      # gpg: Good signature from "Max Reitz <mreitz@redhat.com>" [full]
      # Primary key fingerprint: 91BE B60A 30DB 3E88 57D1  1829 F407 DB00 61D5 CF40
      
      * remotes/maxreitz/tags/pull-block-2020-08-11:
        iotests: add test for unaligned granularity bitmap backup
        block/block-copy: always align copied region to cluster size
      
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      1d806cef
  3. Aug 18, 2020
  4. Aug 11, 2020
  5. Aug 10, 2020
  6. Aug 05, 2020
    • Peter Maydell's avatar
      e1d322c4
    • Peter Maydell's avatar
      target/arm: Fix Rt/Rt2 in ESR_ELx for copro traps from AArch32 to 64 · a65dabf7
      Peter Maydell authored
      When a coprocessor instruction in an  AArch32 guest traps to AArch32
      Hyp mode, the syndrome register (HSR) includes Rt and Rt2 fields
      which are simply copies of the Rt and Rt2 fields from the trapped
      instruction.  However, if the instruction is trapped from AArch32 to
      an AArch64 higher exception level, the Rt and Rt2 fields in the
      syndrome register (ESR_ELx) must be the AArch64 view of the register.
      This makes a difference if the AArch32 guest was in a mode other than
      User or System and it was using r13 or r14, or if it was in FIQ mode
      and using r8-r14.
      
      We don't know at translate time which AArch32 CPU mode we are in, so
      we leave the values we generate in our prototype syndrome register
      value at translate time as the raw Rt/Rt2 from the instruction, and
      instead correct them to the AArch64 view when we find we need to take
      an exception from AArch32 to AArch64 with one of these syndrome
      values.
      
      Fixes: https://bugs.launchpad.net/qemu/+bug/1879587
      
      
      Reported-by: default avatarJulien Freche <julien@bedrocksystems.com>
      Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      Message-id: 20200804193903.31240-1-peter.maydell@linaro.org
      a65dabf7
    • Tuguoyi's avatar
      qcow2-cluster: Fix integer left shift error in qcow2_alloc_cluster_link_l2() · 348fcc4f
      Tuguoyi authored
      
      When calculating the offset, the result of left shift operation will be promoted
      to type int64 automatically because the left operand of + operator is uint64_t.
      but the result after integer promotion may be produce an error value for us and
      trigger the following asserting error.
      
      For example, consider i=0x2000, cluster_bits=18, the result of left shift
      operation will be 0x80000000. Cause argument i is of signed integer type,
      the result is automatically promoted to 0xffffffff80000000 which is not
      we expected
      
      The way to trigger the assertion error:
        qemu-img create -f qcow2 -o preallocation=full,cluster_size=256k tmpdisk 10G
      
      This patch fix it by casting @i to uint64_t before doing left shift operation
      
      Signed-off-by: default avatarGuoyi Tu <tu.guoyi@h3c.com>
      Reviewed-by: default avatarEric Blake <eblake@redhat.com>
      Reviewed-by: default avatarKevin Wolf <kwolf@redhat.com>
      Reviewed-by: default avatarAlberto Garcia <berto@igalia.com>
      Message-id: 81ba90fe0c014f269621c283269b42ad@h3c.com
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      348fcc4f
    • Peter Maydell's avatar
      Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-08-05' into staging · 616dab9a
      Peter Maydell authored
      
      * Test rx-softmmu, avr-softmmu, Centos7 and Debian on gitlab-CI
      * Fix compiler warning on 32-bit big endian systems
      * Remove remainders of libqemustub.a
      
      # gpg: Signature made Wed 05 Aug 2020 10:51:32 BST
      # gpg:                using RSA key 27B88847EEE0250118F3EAB92ED9D774FE702DB5
      # gpg:                issuer "thuth@redhat.com"
      # gpg: Good signature from "Thomas Huth <th.huth@gmx.de>" [full]
      # gpg:                 aka "Thomas Huth <thuth@redhat.com>" [full]
      # gpg:                 aka "Thomas Huth <huth@tuxfamily.org>" [full]
      # gpg:                 aka "Thomas Huth <th.huth@posteo.de>" [unknown]
      # Primary key fingerprint: 27B8 8847 EEE0 2501 18F3  EAB9 2ED9 D774 FE70 2DB5
      
      * remotes/huth-gitlab/tags/pull-request-2020-08-05:
        Get rid of the libqemustub.a remainders
        target/riscv/vector_helper: Fix build on 32-bit big endian hosts
        gitlab-ci: Fix Avocado cache usage
        gitlab-ci.yml: Add build-system-debian and build-system-centos jobs
        tests/acceptance: Disable the rx sash and arm cubieboard replay test on Gitlab
        tests/docker: Add python3-venv and netcat to the debian-amd64 container
      
      Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
      616dab9a
    • Thomas Huth's avatar
      Get rid of the libqemustub.a remainders · d2a71d74
      Thomas Huth authored
      
      libqemustub.a has been removed in commit ebedb37c ("Makefile: Remove
      libqemustub.a"). Some remainders have been missed. Remove them now.
      
      Message-Id: <20200804170055.2851-8-thuth@redhat.com>
      Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
      Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
      d2a71d74
    • Thomas Huth's avatar
      target/riscv/vector_helper: Fix build on 32-bit big endian hosts · 35c7f525
      Thomas Huth authored
      
      The code currently fails to compile on 32-bit big endian hosts:
      
       target/riscv/vector_helper.c: In function 'vext_clear':
       target/riscv/vector_helper.c:154:16: error: cast to pointer from integer
       of different size [-Werror=int-to-pointer-cast]
               memset((void *)((uintptr_t)tail & ~(7ULL)), 0, part1);
                      ^
       target/riscv/vector_helper.c:155:16: error: cast to pointer from integer
       of different size [-Werror=int-to-pointer-cast]
               memset((void *)(((uintptr_t)tail + 8) & ~(7ULL)), 0, part2);
                      ^
       cc1: all warnings being treated as errors
      
      We should not use "long long" (i.e. 64-bit) values here to avoid the
      problem. Switch to our QEMU_ALIGN_PTR_DOWN/UP macros instead.
      
      Fixes: 751538d5 ("add vector stride load and store instructions")
      Suggested-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
      Message-Id: <20200804170055.2851-3-thuth@redhat.com>
      Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
      Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
      35c7f525
    • Thomas Huth's avatar
      gitlab-ci: Fix Avocado cache usage · 5896c539
      Thomas Huth authored
      
      In commit 6957fd98 ("gitlab: add avocado asset caching") we
      tried to save the Avocado cache (as in commit c1073e44 with
      Travis-CI) however it doesn't work as expected. For some reason
      Avocado uses /root/avocado_cache/ which we can not select later.
      
      Manually generate a Avocado config to force the use of the
      current job's directory.
      
      This patch is based on an earlier version from Philippe Mathieu-Daudé.
      
      Message-Id: <20200730141326.8260-5-thuth@redhat.com>
      Reviewed-by: default avatarAlex Bennée <alex.bennee@linaro.org>
      Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
      5896c539
Loading