Warn user if the vga flag is passed but no vga device is created
A global boolean variable "vga_interface_created"(declared in softmmu/globals.c) has been used to track the creation of vga interface. If the vga flag is passed in the command line "default_vga"(declared in softmmu/vl.c) variable is set to 0. To warn user, the condition checks if vga_interface_created is false and default_vga is equal to 0. If "-vga none" is passed, this patch will not warn the user regarding the creation of VGA device. The warning "A -vga option was passed but this machine type does not use that option; no VGA device has been created" is logged if vga flag is passed but no vga device is created. This patch has been tested for x86_64, i386, sparc, sparc64 and arm boards. Signed-off-by:Gautam Agrawal <gautamnagrawal@gmail.com> Reviewed-by:
Peter Maydell <peter.maydell@linaro.org> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/581 Message-Id: <20220501122505.29202-1-gautamnagrawal@gmail.com> [thuth: Fix wrong warning with "-device" in some cases as reported by Paolo] Signed-off-by:
Thomas Huth <thuth@redhat.com>
Showing
- hw/hppa/machine.c 1 addition, 0 deletionshw/hppa/machine.c
- hw/isa/isa-bus.c 1 addition, 0 deletionshw/isa/isa-bus.c
- hw/mips/fuloong2e.c 1 addition, 0 deletionshw/mips/fuloong2e.c
- hw/pci/pci.c 1 addition, 0 deletionshw/pci/pci.c
- hw/ppc/spapr.c 1 addition, 0 deletionshw/ppc/spapr.c
- hw/sparc/sun4m.c 2 additions, 0 deletionshw/sparc/sun4m.c
- hw/sparc64/sun4u.c 1 addition, 0 deletionshw/sparc64/sun4u.c
- hw/xenpv/xen_machine_pv.c 1 addition, 0 deletionshw/xenpv/xen_machine_pv.c
- include/sysemu/sysemu.h 1 addition, 0 deletionsinclude/sysemu/sysemu.h
- softmmu/globals.c 1 addition, 0 deletionssoftmmu/globals.c
- softmmu/vl.c 7 additions, 0 deletionssoftmmu/vl.c
Loading
Please register or sign in to comment