Skip to content
Snippets Groups Projects
Commit f81cddfe authored by Lukas Straub's avatar Lukas Straub Committed by Jason Wang
Browse files

colo-compare: Remove superfluous NULL-pointer checks for s->iothread


s->iothread is checked for NULL on object creation in colo_compare_complete,
so it's guaranteed not to be NULL.
This resolves a false alert from Coverity (CID 1429969).

Signed-off-by: default avatarLukas Straub <lukasstraub2@web.de>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarLi Qiang <liq3ea@gmail.com>
Reviewed-by: default avatarZhang Chen <chen.zhang@intel.com>
Signed-off-by: default avatarJason Wang <jasowang@redhat.com>
parent 5c1c3e4f
No related branches found
No related tags found
No related merge requests found
...@@ -1442,9 +1442,7 @@ static void colo_compare_finalize(Object *obj) ...@@ -1442,9 +1442,7 @@ static void colo_compare_finalize(Object *obj)
qemu_chr_fe_deinit(&s->chr_notify_dev, false); qemu_chr_fe_deinit(&s->chr_notify_dev, false);
} }
if (s->iothread) { colo_compare_timer_del(s);
colo_compare_timer_del(s);
}
qemu_bh_delete(s->event_bh); qemu_bh_delete(s->event_bh);
...@@ -1470,9 +1468,7 @@ static void colo_compare_finalize(Object *obj) ...@@ -1470,9 +1468,7 @@ static void colo_compare_finalize(Object *obj)
g_hash_table_destroy(s->connection_track_table); g_hash_table_destroy(s->connection_track_table);
} }
if (s->iothread) { object_unref(OBJECT(s->iothread));
object_unref(OBJECT(s->iothread));
}
g_free(s->pri_indev); g_free(s->pri_indev);
g_free(s->sec_indev); g_free(s->sec_indev);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment