Skip to content
Snippets Groups Projects
Commit f18d403f authored by Greg Kurz's avatar Greg Kurz Committed by Laurent Vivier
Browse files

softmmu/physmem.c: Fix typo in comment


Fix the comment to match what the code is doing, as explained in
the changelog of commit 86cf9e15
that introduced the change:

    Commit 9458a9a1 added synchronization
    of vCPU and migration operations through calling run_on_cpu operation.
    However, in replay mode this synchronization is unneeded, because
    I/O and vCPU threads are already synchronized.
    This patch disables such synchronization for record/replay mode.

Signed-off-by: default avatarGreg Kurz <groug@kaod.org>
Reviewed-by: default avatarDavid Hildenbrand <david@redhat.com>
Message-Id: <163429018454.1146856.3429437540871060739.stgit@bahia.huguette>
Signed-off-by: default avatarLaurent Vivier <laurent@vivier.eu>
parent 3bc1bb80
No related branches found
No related tags found
No related merge requests found
......@@ -2633,7 +2633,7 @@ static void tcg_log_global_after_sync(MemoryListener *listener)
* In record/replay mode this causes a deadlock, because
* run_on_cpu waits for rr mutex. Therefore no races are possible
* in this case and no need for making run_on_cpu when
* record/replay is not enabled.
* record/replay is enabled.
*/
cpuas = container_of(listener, CPUAddressSpace, tcg_as_listener);
run_on_cpu(cpuas->cpu, do_nothing, RUN_ON_CPU_NULL);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment