Skip to content
Snippets Groups Projects
Commit eaae29ef authored by Kevin Wolf's avatar Kevin Wolf
Browse files

qemu-storage-daemon: Fix non-string --object properties


After processing the option string with the keyval parser, we get a
QDict that contains only strings. This QDict must be fed to a keyval
visitor which converts the strings into the right data types.

qmp_object_add(), however, uses the normal QObject input visitor, which
expects a QDict where all properties already have the QType that matches
the data type required by the QOM object type.

Change the --object implementation in qemu-storage-daemon so that it
doesn't call qmp_object_add(), but calls user_creatable_add_dict()
directly instead and pass it a new keyval boolean that decides which
visitor must be used.

Reported-by: default avatarCoiby Xu <coiby.xu@gmail.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
parent d6a5beeb
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment