error: Use error_prepend() where it makes obvious sense
Done with this Coccinelle semantic patch @@ expression FMT, E1, E2; expression list ARGS; @@ - error_setg(E1, FMT, ARGS, error_get_pretty(E2)); + error_propagate(E1, E2);/*###*/ + error_prepend(E1, FMT/*@@@*/, ARGS); followed by manual cleanup, first because I can't figure out how to make Coccinelle transform strings, and second to get rid of now superfluous error_propagate(). We now use or propagate the original error whole instead of just its message obtained with error_get_pretty(). This avoids suppressing its hint (see commit 50b7b000), but I can't see how the errors touched in this commit could come with hints. It also improves the message printed with &error_abort when we screw up (see commit 1e9b65bb). Signed-off-by:Markus Armbruster <armbru@redhat.com> Reviewed-by:
Eric Blake <eblake@redhat.com>
Showing
- block.c 8 additions, 11 deletionsblock.c
- block/qcow2.c 2 additions, 3 deletionsblock/qcow2.c
- block/qed.c 2 additions, 3 deletionsblock/qed.c
- hw/block/dataplane/virtio-blk.c 2 additions, 6 deletionshw/block/dataplane/virtio-blk.c
- hw/scsi/vhost-scsi.c 2 additions, 4 deletionshw/scsi/vhost-scsi.c
- hw/usb/bus.c 3 additions, 3 deletionshw/usb/bus.c
Loading
Please register or sign in to comment