Skip to content
Snippets Groups Projects
Commit df67aa3e authored by Leonardo Bras's avatar Leonardo Bras Committed by Dr. David Alan Gilbert
Browse files

migration: add remaining params->has_* = true in migration_instance_init()


Some of params->has_* = true are missing in migration_instance_init, this
causes migrate_params_check() to skip some tests, allowing some
unsupported scenarios.

Fix this by adding all missing params->has_* = true in
migration_instance_init().

Fixes: 69ef1f36 ("migration: define 'tls-creds' and 'tls-hostname' migration parameters")
Fixes: 1d58872a ("migration: do not wait for free thread")
Fixes: d2f1d29b ("migration: add support for a "tls-authz" migration parameter")
Signed-off-by: default avatarLeonardo Bras <leobras@redhat.com>
Message-Id: <20220726010235.342927-1-leobras@redhat.com>
Reviewed-by: default avatarPeter Xu <peterx@redhat.com>
Signed-off-by: default avatarDr. David Alan Gilbert <dgilbert@redhat.com>
parent 0399521e
No related branches found
No related tags found
No related merge requests found
...@@ -4451,6 +4451,7 @@ static void migration_instance_init(Object *obj) ...@@ -4451,6 +4451,7 @@ static void migration_instance_init(Object *obj)
/* Set has_* up only for parameter checks */ /* Set has_* up only for parameter checks */
params->has_compress_level = true; params->has_compress_level = true;
params->has_compress_threads = true; params->has_compress_threads = true;
params->has_compress_wait_thread = true;
params->has_decompress_threads = true; params->has_decompress_threads = true;
params->has_throttle_trigger_threshold = true; params->has_throttle_trigger_threshold = true;
params->has_cpu_throttle_initial = true; params->has_cpu_throttle_initial = true;
...@@ -4471,6 +4472,9 @@ static void migration_instance_init(Object *obj) ...@@ -4471,6 +4472,9 @@ static void migration_instance_init(Object *obj)
params->has_announce_max = true; params->has_announce_max = true;
params->has_announce_rounds = true; params->has_announce_rounds = true;
params->has_announce_step = true; params->has_announce_step = true;
params->has_tls_creds = true;
params->has_tls_hostname = true;
params->has_tls_authz = true;
qemu_sem_init(&ms->postcopy_pause_sem, 0); qemu_sem_init(&ms->postcopy_pause_sem, 0);
qemu_sem_init(&ms->postcopy_pause_rp_sem, 0); qemu_sem_init(&ms->postcopy_pause_rp_sem, 0);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment