nbd: Add 'qemu-nbd -A' to expose allocation depth
Allow the server to expose an additional metacontext to be requested by savvy clients. qemu-nbd adds a new option -A to expose the qemu:allocation-depth metacontext through NBD_CMD_BLOCK_STATUS; this can also be set via QMP when using block-export-add. qemu as client is hacked into viewing the key aspects of this new context by abusing the already-experimental x-dirty-bitmap option to collapse all depths greater than 2, which results in a tri-state value visible in the output of 'qemu-img map --output=json' (yes, that means x-dirty-bitmap is now a bit of a misnomer, but I didn't feel like renaming it as it would introduce a needless break of back-compat, even though we make no compat guarantees with x- members): unallocated (depth 0) => "zero":false, "data":true local (depth 1) => "zero":false, "data":false backing (depth 2+) => "zero":true, "data":true libnbd as client is probably a nicer way to get at the information without having to decipher such hacks in qemu as client. ;) Signed-off-by:Eric Blake <eblake@redhat.com> Message-Id: <20201027050556.269064-11-eblake@redhat.com> Reviewed-by:
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Showing
- block/nbd.c 21 additions, 5 deletionsblock/nbd.c
- docs/tools/qemu-nbd.rst 7 additions, 1 deletiondocs/tools/qemu-nbd.rst
- nbd/server.c 2 additions, 0 deletionsnbd/server.c
- qapi/block-core.json 5 additions, 2 deletionsqapi/block-core.json
- qapi/block-export.json 6 additions, 1 deletionqapi/block-export.json
- qemu-nbd.c 10 additions, 2 deletionsqemu-nbd.c
- tests/qemu-iotests/309 77 additions, 0 deletionstests/qemu-iotests/309
- tests/qemu-iotests/309.out 22 additions, 0 deletionstests/qemu-iotests/309.out
- tests/qemu-iotests/group 1 addition, 0 deletionstests/qemu-iotests/group
Loading
Please register or sign in to comment