Include qemu/main-loop.h less
In my "build everything" tree, changing qemu/main-loop.h triggers a recompile of some 5600 out of 6600 objects (not counting tests and objects that don't depend on qemu/osdep.h). It includes block/aio.h, which in turn includes qemu/event_notifier.h, qemu/notify.h, qemu/processor.h, qemu/qsp.h, qemu/queue.h, qemu/thread-posix.h, qemu/thread.h, qemu/timer.h, and a few more. Include qemu/main-loop.h only where it's needed. Touching it now recompiles only some 1700 objects. For block/aio.h and qemu/event_notifier.h, these numbers drop from 5600 to 2800. For the others, they shrink only slightly. Signed-off-by:Markus Armbruster <armbru@redhat.com> Message-Id: <20190812052359.30071-21-armbru@redhat.com> Reviewed-by:
Alex Bennée <alex.bennee@linaro.org> Reviewed-by:
Philippe Mathieu-Daudé <philmd@redhat.com> Tested-by:
Philippe Mathieu-Daudé <philmd@redhat.com>
Showing
- accel/kvm/kvm-all.c 1 addition, 0 deletionsaccel/kvm/kvm-all.c
- block.c 1 addition, 0 deletionsblock.c
- block/block-backend.c 1 addition, 0 deletionsblock/block-backend.c
- block/create.c 1 addition, 0 deletionsblock/create.c
- block/io.c 1 addition, 0 deletionsblock/io.c
- block/nbd.c 1 addition, 0 deletionsblock/nbd.c
- block/nfs.c 1 addition, 0 deletionsblock/nfs.c
- block/nvme.c 1 addition, 0 deletionsblock/nvme.c
- block/qcow2.c 1 addition, 0 deletionsblock/qcow2.c
- block/qed.c 1 addition, 0 deletionsblock/qed.c
- block/sheepdog.c 1 addition, 0 deletionsblock/sheepdog.c
- block/throttle-groups.c 1 addition, 0 deletionsblock/throttle-groups.c
- blockdev.c 1 addition, 0 deletionsblockdev.c
- blockjob.c 1 addition, 0 deletionsblockjob.c
- chardev/baum.c 1 addition, 0 deletionschardev/baum.c
- chardev/char-pipe.c 1 addition, 0 deletionschardev/char-pipe.c
- chardev/char-win-stdio.c 1 addition, 0 deletionschardev/char-win-stdio.c
- chardev/char-win.c 1 addition, 0 deletionschardev/char-win.c
- dump/dump.c 1 addition, 0 deletionsdump/dump.c
- fsdev/qemu-fsdev-throttle.c 1 addition, 0 deletionsfsdev/qemu-fsdev-throttle.c
Loading
Please register or sign in to comment