Skip to content
Snippets Groups Projects
Commit cf734c2a authored by Peter Maydell's avatar Peter Maydell
Browse files

hw/intc/arm_gicv3_cpuif: Fix register names in ICV_HPPIR read trace event


The trace_gicv3_icv_hppir_read trace event takes an integer value
which it uses to form the register name, which should be either
ICV_HPPIR0 or ICV_HPPIR1.  We were passing in the 'grp' variable for
this, but that is either GICV3_G0 or GICV3_G1NS, which happen to be 0
and 2, which meant that tracing for the ICV_HPPIR1 register was
incorrectly printed as ICV_HPPIR2.

Use the same approach we do for all the other similar trace events,
and pass in 'ri->crm == 8 ?  0 : 1', deriving the index value
directly from the ARMCPRegInfo struct.

Signed-off-by: default avatarPeter Maydell <peter.maydell@linaro.org>
Reviewed-by: default avatarRichard Henderson <richard.henderson@linaro.org>
Message-id: 20220303202341.2232284-6-peter.maydell@linaro.org
parent b45f91e1
No related branches found
No related tags found
No related merge requests found
......@@ -612,7 +612,8 @@ static uint64_t icv_hppir_read(CPUARMState *env, const ARMCPRegInfo *ri)
}
}
trace_gicv3_icv_hppir_read(grp, gicv3_redist_affid(cs), value);
trace_gicv3_icv_hppir_read(ri->crm == 8 ? 0 : 1,
gicv3_redist_affid(cs), value);
return value;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment