Skip to content
Snippets Groups Projects
Commit cc2b4550 authored by BALATON Zoltan's avatar BALATON Zoltan Committed by Philippe Mathieu-Daudé
Browse files

vt82c686: Fix superio_cfg_{read,write}() functions


These functions are memory region callbacks so we have to check
against relative address not the mapped address.

Signed-off-by: default avatarBALATON Zoltan <balaton@eik.bme.hu>
Message-Id: <15b2968fd300a12d06b42368d084f6f80d3c3be5.1610223397.git.balaton@eik.bme.hu>
[PMD: Split original patch in 5, this is part 5/5]
Signed-off-by: default avatarPhilippe Mathieu-Daudé <f4bug@amsat.org>
parent 2c4c556e
No related branches found
No related tags found
No related merge requests found
......@@ -260,12 +260,13 @@ static void superio_cfg_write(void *opaque, hwaddr addr, uint64_t data,
SuperIOConfig *sc = opaque;
uint8_t idx = sc->regs[0];
if (addr == 0x3f0) { /* config index register */
idx = data & 0xff;
if (addr == 0) { /* config index register */
sc->regs[0] = data;
return;
}
/* 0x3f1, config data register */
trace_via_superio_write(idx, data & 0xff);
/* config data register */
trace_via_superio_write(idx, data);
switch (idx) {
case 0x00 ... 0xdf:
case 0xe4:
......@@ -284,7 +285,7 @@ static void superio_cfg_write(void *opaque, hwaddr addr, uint64_t data,
"via_superio_cfg: unimplemented register 0x%x\n", idx);
break;
}
sc->regs[idx] = data & 0xff;
sc->regs[idx] = data;
}
static uint64_t superio_cfg_read(void *opaque, hwaddr addr, unsigned size)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment