migration: simplify blockers
Modify migrate_add_blocker and migrate_del_blocker to take an Error ** reason. This allows migration to own the Error object, so that if an error occurs in migrate_add_blocker, migration code can free the Error and clear the client handle, simplifying client code. It also simplifies the migrate_del_blocker call site. In addition, this is a pre-requisite for a proposed future patch that would add a mode argument to migration requests to support live update, and maintain a list of blockers for each mode. A blocker may apply to a single mode or to multiple modes, and passing Error** will allow one Error object to be registered for multiple modes. No functional change. Signed-off-by:Steve Sistare <steven.sistare@oracle.com> Tested-by:
Michael Galaxy <mgalaxy@akamai.com> Reviewed-by:
Michael Galaxy <mgalaxy@akamai.com> Reviewed-by:
Peter Xu <peterx@redhat.com> Reviewed-by:
Juan Quintela <quintela@redhat.com> Signed-off-by:
Juan Quintela <quintela@redhat.com> Message-ID: <1697634216-84215-1-git-send-email-steven.sistare@oracle.com>
Showing
- backends/tpm/tpm_emulator.c 2 additions, 8 deletionsbackends/tpm/tpm_emulator.c
- block/parallels.c 3 additions, 6 deletionsblock/parallels.c
- block/qcow.c 2 additions, 4 deletionsblock/qcow.c
- block/vdi.c 2 additions, 4 deletionsblock/vdi.c
- block/vhdx.c 2 additions, 4 deletionsblock/vhdx.c
- block/vmdk.c 2 additions, 4 deletionsblock/vmdk.c
- block/vpc.c 2 additions, 4 deletionsblock/vpc.c
- block/vvfat.c 2 additions, 4 deletionsblock/vvfat.c
- dump/dump.c 2 additions, 2 deletionsdump/dump.c
- hw/9pfs/9p.c 2 additions, 8 deletionshw/9pfs/9p.c
- hw/display/virtio-gpu-base.c 2 additions, 6 deletionshw/display/virtio-gpu-base.c
- hw/intc/arm_gic_kvm.c 1 addition, 2 deletionshw/intc/arm_gic_kvm.c
- hw/intc/arm_gicv3_its_kvm.c 1 addition, 2 deletionshw/intc/arm_gicv3_its_kvm.c
- hw/intc/arm_gicv3_kvm.c 1 addition, 2 deletionshw/intc/arm_gicv3_kvm.c
- hw/misc/ivshmem.c 2 additions, 6 deletionshw/misc/ivshmem.c
- hw/ppc/pef.c 1 addition, 1 deletionhw/ppc/pef.c
- hw/ppc/spapr.c 1 addition, 8 deletionshw/ppc/spapr.c
- hw/ppc/spapr_events.c 5 additions, 1 deletionhw/ppc/spapr_events.c
- hw/ppc/spapr_rtas.c 1 addition, 1 deletionhw/ppc/spapr_rtas.c
- hw/remote/proxy.c 2 additions, 5 deletionshw/remote/proxy.c
Loading
Please register or sign in to comment