Skip to content
Snippets Groups Projects
Commit c5f3014b authored by Kevin Wolf's avatar Kevin Wolf
Browse files

block: Add bdrv_runtime_opts to query-command-line-options


Recently we moved a few options from QemuOptsLists in blockdev.c to
bdrv_runtime_opts in block.c in order to make them accissble using
blockdev-add. However, this has the side effect that these options are
missing from query-command-line-options now, and libvirt consequently
disables the corresponding feature.

This problem was reported as a regression for the 'discard' option,
introduced in commit 818584a4. However, it is more general than that.

Fix it by adding bdrv_runtime_opts to the list of QemuOptsLists that are
returned in query-command-line-options. For the future, libvirt is
advised to use QMP schema introspection for block device options.

Reported-by: default avatarMichal Privoznik <mprivozn@redhat.com>
Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
Tested-by: default avatarMichal Privoznik <mprivozn@redhat.com>
Tested-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent fffb6e12
No related branches found
No related tags found
No related merge requests found
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment