QemuOpts: Drop qemu_opts_foreach() parameter abort_on_failure
When the argument is non-zero, qemu_opts_foreach() stops on callback returning non-zero, and returns that value. When the argument is zero, it doesn't stop, and returns the bit-wise inclusive or of all the return values. Funky :) The callers that pass zero could just as well pass one, because their callbacks can't return anything but zero: * qemu_add_globals()'s callback qdev_add_one_global() * qemu_config_write()'s callback config_write_opts() * main()'s callbacks default_driver_check(), drive_enable_snapshot(), vnc_init_func() Drop the parameter, and always stop. Signed-off-by:Markus Armbruster <armbru@redhat.com> Reviewed-by:
Eric Blake <eblake@redhat.com> Acked-by:
Kevin Wolf <kwolf@redhat.com>
Showing
- block/blkdebug.c 2 additions, 2 deletionsblock/blkdebug.c
- hw/core/qdev-properties-system.c 1 addition, 1 deletionhw/core/qdev-properties-system.c
- include/qemu/option.h 2 additions, 2 deletionsinclude/qemu/option.h
- net/net.c 3 additions, 2 deletionsnet/net.c
- net/vhost-user.c 1 addition, 1 deletionnet/vhost-user.c
- numa.c 1 addition, 2 deletionsnuma.c
- tpm.c 1 addition, 2 deletionstpm.c
- util/qemu-config.c 1 addition, 1 deletionutil/qemu-config.c
- util/qemu-option.c 14 additions, 7 deletionsutil/qemu-option.c
- vl.c 18 additions, 17 deletionsvl.c
Loading
Please register or sign in to comment