block: Clean up a misuse of qobject_to() in .bdrv_co_create_opts()
The following pattern occurs in the .bdrv_co_create_opts() methods of parallels, qcow, qcow2, qed, vhdx and vpc: qobj = qdict_crumple_for_keyval_qiv(qdict, errp); qobject_unref(qdict); qdict = qobject_to(QDict, qobj); if (qdict == NULL) { ret = -EINVAL; goto done; } v = qobject_input_visitor_new_keyval(QOBJECT(qdict)); [...] ret = 0; done: qobject_unref(qdict); [...] return ret; If qobject_to() fails, we return failure without setting errp. That's wrong. As far as I can tell, it cannot fail here. Clean it up anyway, by removing the useless conversion. Signed-off-by:Markus Armbruster <armbru@redhat.com> Reviewed-by:
Kevin Wolf <kwolf@redhat.com> Signed-off-by:
Kevin Wolf <kwolf@redhat.com>
Showing
- block/parallels.c 4 additions, 5 deletionsblock/parallels.c
- block/qcow.c 4 additions, 5 deletionsblock/qcow.c
- block/qcow2.c 4 additions, 5 deletionsblock/qcow2.c
- block/qed.c 4 additions, 5 deletionsblock/qed.c
- block/vhdx.c 4 additions, 5 deletionsblock/vhdx.c
- block/vpc.c 4 additions, 5 deletionsblock/vpc.c
Loading
Please register or sign in to comment