Skip to content
Snippets Groups Projects
Commit 7b59d10e authored by Thomas Huth's avatar Thomas Huth
Browse files

scripts/checkpatch: Improve the check for authors mangled by the mailing list


There were recently some patches on the list which had their "From:"
line mangled like this:

 From: qemu_oss--- via <qemu-devel@nongnu.org>

Since our test in the checkpatch.pl script did not trigger here, the
patches finally also ended up in a pull request, with the wrong author
set. So let's improve the regular expression to also complain on
these new patterns, too.

Message-Id: <20210216071512.1199827-1-thuth@redhat.com>
Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
Reviewed-by: default avatarChristian Schoenebeck <qemu_oss@crudebyte.com>
Signed-off-by: default avatarThomas Huth <thuth@redhat.com>
parent c071f19b
No related branches found
No related tags found
No related merge requests found
......@@ -1499,7 +1499,7 @@ sub process {
$is_patch = 1;
}
if ($line =~ /^Author: .*via Qemu-devel.*<qemu-devel\@nongnu.org>/) {
if ($line =~ /^(Author|From): .* via .*<qemu-devel\@nongnu.org>/) {
ERROR("Author email address is mangled by the mailing list\n" . $herecurr);
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment