Skip to content
Snippets Groups Projects
Commit 5f8679fe authored by Alex Chen's avatar Alex Chen Committed by Gerd Hoffmann
Browse files

vnc: Fix a memleak in vnc_display_connect()


Free the 'sioc' when the qio_channel_socket_connect_sync() fails.

Reported-by: default avatarEuler Robot <euler.robot@huawei.com>
Signed-off-by: default avatarAlex Chen <alex.chen@huawei.com>
Reviewed-by: default avatarLi Qiang <liq3ea@gmail.com>
Reviewed-by: default avatarLaurent Vivier <laurent@vivier.eu>
Message-Id: <20201126065702.35095-1-alex.chen@huawei.com>
Signed-off-by: default avatarGerd Hoffmann <kraxel@redhat.com>
parent 7b5fa0b5
No related branches found
No related tags found
No related merge requests found
......@@ -3805,6 +3805,7 @@ static int vnc_display_connect(VncDisplay *vd,
sioc = qio_channel_socket_new();
qio_channel_set_name(QIO_CHANNEL(sioc), "vnc-reverse");
if (qio_channel_socket_connect_sync(sioc, saddr[0], errp) < 0) {
object_unref(OBJECT(sioc));
return -1;
}
vnc_connect(vd, sioc, false, false);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment