atomics: eliminate mb_read/mb_set
qatomic_mb_read and qatomic_mb_set were the very first atomic primitives introduced for QEMU; their semantics are unclear and they provide a false sense of safety. The last use of qatomic_mb_read() has been removed, so delete it. qatomic_mb_set() instead can survive as an optimized qatomic_set()+smp_mb(), similar to Linux's smp_store_mb(), but rename it to qatomic_set_mb() to match the order of the two operations. Reviewed-by:Richard Henderson <richard.henderson@linaro.org> Signed-off-by:
Paolo Bonzini <pbonzini@redhat.com>
Showing
- accel/tcg/cpu-exec.c 1 addition, 1 deletionaccel/tcg/cpu-exec.c
- accel/tcg/tcg-accel-ops-mttcg.c 1 addition, 1 deletionaccel/tcg/tcg-accel-ops-mttcg.c
- accel/tcg/tcg-accel-ops-rr.c 2 additions, 2 deletionsaccel/tcg/tcg-accel-ops-rr.c
- docs/devel/atomics.rst 4 additions, 23 deletionsdocs/devel/atomics.rst
- include/qemu/atomic.h 5 additions, 12 deletionsinclude/qemu/atomic.h
- monitor/qmp.c 1 addition, 1 deletionmonitor/qmp.c
- softmmu/cpus.c 1 addition, 1 deletionsoftmmu/cpus.c
- softmmu/physmem.c 1 addition, 1 deletionsoftmmu/physmem.c
- target/arm/hvf/hvf.c 1 addition, 1 deletiontarget/arm/hvf/hvf.c
- tests/unit/test-aio-multithread.c 1 addition, 1 deletiontests/unit/test-aio-multithread.c
- util/qemu-coroutine-lock.c 2 additions, 2 deletionsutil/qemu-coroutine-lock.c
Loading
Please register or sign in to comment