Skip to content
Snippets Groups Projects
Commit 02c2b87f authored by Anthony Liguori's avatar Anthony Liguori
Browse files

vnc: hextile: do not generate ForegroundSpecified and SubrectsColoured tiles


This violates the RFB specification (section 6.6.4).  It happens to work with
most clients but it's still wrong.

Reported-by: default avatarYaniv Kaul <ykaul@redhat.com>
Signed-off-by: default avatarAnthony Liguori <aliguori@us.ibm.com>
parent d587e078
No related branches found
No related tags found
No related merge requests found
......@@ -73,7 +73,7 @@ static void CONCAT(send_hextile_tile_, NAME)(VncState *vs,
*last_bg = bg;
}
if (!*has_fg || *last_fg != fg) {
if (n_colors < 3 && (!*has_fg || *last_fg != fg)) {
flags |= 0x04;
*has_fg = 1;
*last_fg = fg;
......@@ -165,8 +165,6 @@ static void CONCAT(send_hextile_tile_, NAME)(VncState *vs,
irow += ds_get_linesize(vs->ds) / sizeof(pixel_t);
}
/* A SubrectsColoured subtile invalidates the foreground color */
*has_fg = 0;
if (n_data > (w * h * sizeof(pixel_t))) {
n_colors = 4;
flags = 0x01;
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment