Skip to content
Snippets Groups Projects
  • Stefan Hajnoczi's avatar
    d73415a3
    qemu/atomic.h: rename atomic_ to qatomic_ · d73415a3
    Stefan Hajnoczi authored
    
    clang's C11 atomic_fetch_*() functions only take a C11 atomic type
    pointer argument. QEMU uses direct types (int, etc) and this causes a
    compiler error when a QEMU code calls these functions in a source file
    that also included <stdatomic.h> via a system header file:
    
      $ CC=clang CXX=clang++ ./configure ... && make
      ../util/async.c:79:17: error: address argument to atomic operation must be a pointer to _Atomic type ('unsigned int *' invalid)
    
    Avoid using atomic_*() names in QEMU's atomic.h since that namespace is
    used by <stdatomic.h>. Prefix QEMU's APIs with 'q' so that atomic.h
    and <stdatomic.h> can co-exist. I checked /usr/include on my machine and
    searched GitHub for existing "qatomic_" users but there seem to be none.
    
    This patch was generated using:
    
      $ git grep -h -o '\<atomic\(64\)\?_[a-z0-9_]\+' include/qemu/atomic.h | \
        sort -u >/tmp/changed_identifiers
      $ for identifier in $(</tmp/changed_identifiers); do
            sed -i "s%\<$identifier\>%q$identifier%g" \
                $(git grep -I -l "\<$identifier\>")
        done
    
    I manually fixed line-wrap issues and misaligned rST tables.
    
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
    Acked-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Message-Id: <20200923105646.47864-1-stefanha@redhat.com>
    d73415a3
    History
    qemu/atomic.h: rename atomic_ to qatomic_
    Stefan Hajnoczi authored
    
    clang's C11 atomic_fetch_*() functions only take a C11 atomic type
    pointer argument. QEMU uses direct types (int, etc) and this causes a
    compiler error when a QEMU code calls these functions in a source file
    that also included <stdatomic.h> via a system header file:
    
      $ CC=clang CXX=clang++ ./configure ... && make
      ../util/async.c:79:17: error: address argument to atomic operation must be a pointer to _Atomic type ('unsigned int *' invalid)
    
    Avoid using atomic_*() names in QEMU's atomic.h since that namespace is
    used by <stdatomic.h>. Prefix QEMU's APIs with 'q' so that atomic.h
    and <stdatomic.h> can co-exist. I checked /usr/include on my machine and
    searched GitHub for existing "qatomic_" users but there seem to be none.
    
    This patch was generated using:
    
      $ git grep -h -o '\<atomic\(64\)\?_[a-z0-9_]\+' include/qemu/atomic.h | \
        sort -u >/tmp/changed_identifiers
      $ for identifier in $(</tmp/changed_identifiers); do
            sed -i "s%\<$identifier\>%q$identifier%g" \
                $(git grep -I -l "\<$identifier\>")
        done
    
    I manually fixed line-wrap issues and misaligned rST tables.
    
    Signed-off-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    Reviewed-by: default avatarPhilippe Mathieu-Daudé <philmd@redhat.com>
    Acked-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    Message-Id: <20200923105646.47864-1-stefanha@redhat.com>
iothread.c 3.36 KiB
/*
 * Event loop thread implementation for unit tests
 *
 * Copyright Red Hat Inc., 2013, 2016
 *
 * Authors:
 *  Stefan Hajnoczi   <stefanha@redhat.com>
 *  Paolo Bonzini     <pbonzini@redhat.com>
 *
 * This work is licensed under the terms of the GNU GPL, version 2 or later.
 * See the COPYING file in the top-level directory.
 *
 */

#include "qemu/osdep.h"
#include "qapi/error.h"
#include "block/aio.h"
#include "qemu/main-loop.h"
#include "qemu/rcu.h"
#include "iothread.h"

struct IOThread {
    AioContext *ctx;
    GMainContext *worker_context;
    GMainLoop *main_loop;

    QemuThread thread;
    QemuMutex init_done_lock;
    QemuCond init_done_cond;    /* is thread initialization done? */
    bool stopping;
};

static __thread IOThread *my_iothread;

AioContext *qemu_get_current_aio_context(void)
{
    return my_iothread ? my_iothread->ctx : qemu_get_aio_context();
}

static void iothread_init_gcontext(IOThread *iothread)
{
    GSource *source;

    iothread->worker_context = g_main_context_new();
    source = aio_get_g_source(iothread_get_aio_context(iothread));
    g_source_attach(source, iothread->worker_context);
    g_source_unref(source);
    iothread->main_loop = g_main_loop_new(iothread->worker_context, TRUE);
}

static void *iothread_run(void *opaque)
{
    IOThread *iothread = opaque;

    rcu_register_thread();

    my_iothread = iothread;
    qemu_mutex_lock(&iothread->init_done_lock);
    iothread->ctx = aio_context_new(&error_abort);

    /*
     * We must connect the ctx to a GMainContext, because in older versions
     * of glib the g_source_ref()/unref() functions are not threadsafe
     * on sources without a context.
     */
    iothread_init_gcontext(iothread);

    /*
     * g_main_context_push_thread_default() must be called before anything
     * in this new thread uses glib.
     */
    g_main_context_push_thread_default(iothread->worker_context);

    qemu_cond_signal(&iothread->init_done_cond);
    qemu_mutex_unlock(&iothread->init_done_lock);

    while (!qatomic_read(&iothread->stopping)) {
        aio_poll(iothread->ctx, true);
    }

    g_main_context_pop_thread_default(iothread->worker_context);
    rcu_unregister_thread();
    return NULL;
}

static void iothread_stop_bh(void *opaque)
{
    IOThread *iothread = opaque;

    iothread->stopping = true;
}

void iothread_join(IOThread *iothread)
{
    aio_bh_schedule_oneshot(iothread->ctx, iothread_stop_bh, iothread);
    qemu_thread_join(&iothread->thread);
    g_main_context_unref(iothread->worker_context);
    g_main_loop_unref(iothread->main_loop);
    qemu_cond_destroy(&iothread->init_done_cond);
    qemu_mutex_destroy(&iothread->init_done_lock);
    aio_context_unref(iothread->ctx);
    g_free(iothread);
}

IOThread *iothread_new(void)
{
    IOThread *iothread = g_new0(IOThread, 1);

    qemu_mutex_init(&iothread->init_done_lock);
    qemu_cond_init(&iothread->init_done_cond);
    qemu_thread_create(&iothread->thread, NULL, iothread_run,
                       iothread, QEMU_THREAD_JOINABLE);

    /* Wait for initialization to complete */
    qemu_mutex_lock(&iothread->init_done_lock);
    while (iothread->ctx == NULL) {
        qemu_cond_wait(&iothread->init_done_cond,
                       &iothread->init_done_lock);
    }
    qemu_mutex_unlock(&iothread->init_done_lock);
    return iothread;
}

AioContext *iothread_get_aio_context(IOThread *iothread)
{
    return iothread->ctx;
}