Skip to content
Snippets Groups Projects
  • Kevin Wolf's avatar
    e5f05f8c
    block: Add option to use driver whitelist even in tools · e5f05f8c
    Kevin Wolf authored
    
    Currently, the block driver whitelists are only applied for the system
    emulator. All other binaries still give unrestricted access to all block
    drivers. There are use cases where this made sense because the main
    concern was avoiding customers running VMs on less optimised block
    drivers and getting bad performance. Allowing the same image format e.g.
    as a target for 'qemu-img convert' is not a problem then.
    
    However, if the concern is the supportability of the driver in general,
    either in full or when used read-write, not applying the list driver
    whitelist in tools doesn't help - especially since qemu-nbd and
    qemu-storage-daemon now give access to more or less the same operations
    in block drivers as running a system emulator.
    
    In order to address this, introduce a new configure option that enforces
    the driver whitelist in all binaries.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Message-Id: <20210709164141.254097-1-kwolf@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    e5f05f8c
    History
    block: Add option to use driver whitelist even in tools
    Kevin Wolf authored
    
    Currently, the block driver whitelists are only applied for the system
    emulator. All other binaries still give unrestricted access to all block
    drivers. There are use cases where this made sense because the main
    concern was avoiding customers running VMs on less optimised block
    drivers and getting bad performance. Allowing the same image format e.g.
    as a target for 'qemu-img convert' is not a problem then.
    
    However, if the concern is the supportability of the driver in general,
    either in full or when used read-write, not applying the list driver
    whitelist in tools doesn't help - especially since qemu-nbd and
    qemu-storage-daemon now give access to more or less the same operations
    in block drivers as running a system emulator.
    
    In order to address this, introduce a new configure option that enforces
    the driver whitelist in all binaries.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Message-Id: <20210709164141.254097-1-kwolf@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>