Skip to content
Snippets Groups Projects
  • Eric Blake's avatar
    54aa3de7
    qapi: Use QAPI_LIST_PREPEND() where possible · 54aa3de7
    Eric Blake authored
    
    Anywhere we create a list of just one item or by prepending items
    (typically because order doesn't matter), we can use
    QAPI_LIST_PREPEND().  But places where we must keep the list in order
    by appending remain open-coded until later patches.
    
    Note that as a side effect, this also performs a cleanup of two minor
    issues in qga/commands-posix.c: the old code was performing
     new = g_malloc0(sizeof(*ret));
    which 1) is confusing because you have to verify whether 'new' and
    'ret' are variables with the same type, and 2) would conflict with C++
    compilation (not an actual problem for this file, but makes
    copy-and-paste harder).
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20201113011340.463563-5-eblake@redhat.com>
    Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Acked-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    [Straightforward conflicts due to commit a8aa94b5 "qga: update
    schema for guest-get-disks 'dependents' field" and commit a10b453a
    "target/mips: Move mips_cpu_add_definition() from helper.c to cpu.c"
    resolved.  Commit message tweaked.]
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    54aa3de7
    History
    qapi: Use QAPI_LIST_PREPEND() where possible
    Eric Blake authored
    
    Anywhere we create a list of just one item or by prepending items
    (typically because order doesn't matter), we can use
    QAPI_LIST_PREPEND().  But places where we must keep the list in order
    by appending remain open-coded until later patches.
    
    Note that as a side effect, this also performs a cleanup of two minor
    issues in qga/commands-posix.c: the old code was performing
     new = g_malloc0(sizeof(*ret));
    which 1) is confusing because you have to verify whether 'new' and
    'ret' are variables with the same type, and 2) would conflict with C++
    compilation (not an actual problem for this file, but makes
    copy-and-paste harder).
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Message-Id: <20201113011340.463563-5-eblake@redhat.com>
    Reviewed-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Acked-by: default avatarStefan Hajnoczi <stefanha@redhat.com>
    [Straightforward conflicts due to commit a8aa94b5 "qga: update
    schema for guest-get-disks 'dependents' field" and commit a10b453a
    "target/mips: Move mips_cpu_add_definition() from helper.c to cpu.c"
    resolved.  Commit message tweaked.]
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>