Skip to content
Snippets Groups Projects
  • Claudio Fontana's avatar
    9b1c9116
    replay: do not build if TCG is not available · 9b1c9116
    Claudio Fontana authored
    
    this fixes non-TCG builds broken recently by replay reverse debugging.
    
    Stub the needed functions in stub/, splitting roughly between functions
    needed only by system emulation, by system emulation and tools,
    and by everyone.  This includes duplicating some code in replay/, and
    puts the logic for non-replay related events in the replay/ module (+
    the stubs), so this should be revisited in the future.
    
    Surprisingly, only _one_ qtest was affected by this, ide-test.c, which
    resulted in a buzz as the bh events were never delivered, and the bh
    never executed.
    
    Many other subsystems _should_ have been affected.
    
    This fixes the immediate issue, however a better way to group replay
    functionality to TCG-only code could be developed in the long term.
    
    Signed-off-by: default avatarClaudio Fontana <cfontana@suse.de>
    Message-Id: <20201013192123.22632-4-cfontana@suse.de>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>
    9b1c9116
    History
    replay: do not build if TCG is not available
    Claudio Fontana authored
    
    this fixes non-TCG builds broken recently by replay reverse debugging.
    
    Stub the needed functions in stub/, splitting roughly between functions
    needed only by system emulation, by system emulation and tools,
    and by everyone.  This includes duplicating some code in replay/, and
    puts the logic for non-replay related events in the replay/ module (+
    the stubs), so this should be revisited in the future.
    
    Surprisingly, only _one_ qtest was affected by this, ide-test.c, which
    resulted in a buzz as the bh events were never delivered, and the bh
    never executed.
    
    Many other subsystems _should_ have been affected.
    
    This fixes the immediate issue, however a better way to group replay
    functionality to TCG-only code could be developed in the long term.
    
    Signed-off-by: default avatarClaudio Fontana <cfontana@suse.de>
    Message-Id: <20201013192123.22632-4-cfontana@suse.de>
    Signed-off-by: default avatarPaolo Bonzini <pbonzini@redhat.com>