Skip to content
Snippets Groups Projects
  • Hanna Reitz's avatar
    c5acdc9a
    block: Release named dirty bitmaps in bdrv_close() · c5acdc9a
    Hanna Reitz authored
    
    bdrv_delete() is not very happy about deleting BlockDriverStates with
    dirty bitmaps still attached to them. In the past, we got around that
    very easily by relying on bdrv_close_all() bypassing bdrv_delete(), and
    bdrv_close() simply ignoring that condition. We should fix that by
    releasing all named dirty bitmaps in bdrv_close() (there should not be
    any unnamed bitmaps left) and moving the assertion from bdrv_delete()
    there.
    
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    c5acdc9a
    History
    block: Release named dirty bitmaps in bdrv_close()
    Hanna Reitz authored
    
    bdrv_delete() is not very happy about deleting BlockDriverStates with
    dirty bitmaps still attached to them. In the past, we got around that
    very easily by relying on bdrv_close_all() bypassing bdrv_delete(), and
    bdrv_close() simply ignoring that condition. We should fix that by
    releasing all named dirty bitmaps in bdrv_close() (there should not be
    any unnamed bitmaps left) and moving the assertion from bdrv_delete()
    there.
    
    Signed-off-by: default avatarMax Reitz <mreitz@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>