Skip to content
Snippets Groups Projects
  • Markus Armbruster's avatar
    ff924448
    backends: Improve error messages when property can no longer be set · ff924448
    Markus Armbruster authored
    
    When you try to set virtio-rng property "filename" after the backend
    has been completed with user_creatable_complete(), the error message
    blames "insufficient permission":
    
        $ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -object rng-random,id=rng0 -device virtio-rng,id=vrng0,rng=rng0
        QEMU 7.1.50 monitor - type 'help' for more information
        (qemu) qom-set /objects/rng0 filename /dev/random
        Error: Insufficient permission to perform this operation
    
    This implies it could work with "sufficient permission".  It can't.
    Change the error message to:
    
        Error: Property 'filename' can no longer be set
    
    Same for cryptodev-vhost-user property "chardev", rng-egd property
    "chardev", and vhost-user-backend property "chardev".
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Message-Id: <20221012153801.2604340-3-armbru@redhat.com>
    Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    [Commit message tidied up]
    ff924448
    History
    backends: Improve error messages when property can no longer be set
    Markus Armbruster authored
    
    When you try to set virtio-rng property "filename" after the backend
    has been completed with user_creatable_complete(), the error message
    blames "insufficient permission":
    
        $ qemu-system-x86_64 -S -display none -nodefaults -monitor stdio -object rng-random,id=rng0 -device virtio-rng,id=vrng0,rng=rng0
        QEMU 7.1.50 monitor - type 'help' for more information
        (qemu) qom-set /objects/rng0 filename /dev/random
        Error: Insufficient permission to perform this operation
    
    This implies it could work with "sufficient permission".  It can't.
    Change the error message to:
    
        Error: Property 'filename' can no longer be set
    
    Same for cryptodev-vhost-user property "chardev", rng-egd property
    "chardev", and vhost-user-backend property "chardev".
    
    Signed-off-by: default avatarMarkus Armbruster <armbru@redhat.com>
    Message-Id: <20221012153801.2604340-3-armbru@redhat.com>
    Acked-by: default avatarMichael S. Tsirkin <mst@redhat.com>
    [Commit message tidied up]