Skip to content
Snippets Groups Projects
  • Priyankar Jain's avatar
    27485832
    dbus-vmstate: Restrict error checks to registered proxies in dbus_get_proxies · 27485832
    Priyankar Jain authored
    
    The purpose of dbus_get_proxies to construct the proxies corresponding to the
    IDs registered to dbus-vmstate.
    
    Currenty, this function returns an error in case there is any failure
    while instantiating proxy for "all" the names on dbus.
    
    Ideally this function should error out only if it is not able to find and
    validate the proxies registered to the backend otherwise any offending
    process(for eg: the process purposefully may not export its Id property on
    the dbus) may connect to the dbus and can lead to migration failures.
    
    This commit ensures that dbus_get_proxies returns an error if it is not
    able to find and validate the proxies of interest(the IDs registered
    during the dbus-vmstate instantiation).
    
    Signed-off-by: default avatarPriyankar Jain <priyankar.jain@nutanix.com>
    Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <1637936117-37977-1-git-send-email-priyankar.jain@nutanix.com>
    27485832
    History
    dbus-vmstate: Restrict error checks to registered proxies in dbus_get_proxies
    Priyankar Jain authored
    
    The purpose of dbus_get_proxies to construct the proxies corresponding to the
    IDs registered to dbus-vmstate.
    
    Currenty, this function returns an error in case there is any failure
    while instantiating proxy for "all" the names on dbus.
    
    Ideally this function should error out only if it is not able to find and
    validate the proxies registered to the backend otherwise any offending
    process(for eg: the process purposefully may not export its Id property on
    the dbus) may connect to the dbus and can lead to migration failures.
    
    This commit ensures that dbus_get_proxies returns an error if it is not
    able to find and validate the proxies of interest(the IDs registered
    during the dbus-vmstate instantiation).
    
    Signed-off-by: default avatarPriyankar Jain <priyankar.jain@nutanix.com>
    Reviewed-by: default avatarMarc-André Lureau <marcandre.lureau@redhat.com>
    Message-Id: <1637936117-37977-1-git-send-email-priyankar.jain@nutanix.com>
dbus-vmstate.c 14.55 KiB