Skip to content
Snippets Groups Projects
  • Vladimir Sementsov-Ogievskiy's avatar
    e5fb29d5
    qapi: nbd-export: allow select bitmaps by node/name pair · e5fb29d5
    Vladimir Sementsov-Ogievskiy authored
    
    Hi all! Current logic of relying on search through backing chain is not
    safe neither convenient.
    
    Sometimes it leads to necessity of extra bitmap copying. Also, we are
    going to add "snapshot-access" driver, to access some snapshot state
    through NBD. And this driver is not formally a filter, and of course
    it's not a COW format driver. So, searching through backing chain will
    not work. Instead of widening the workaround of bitmap searching, let's
    extend the interface so that user can select bitmap precisely.
    
    Note, that checking for bitmap active status is not copied to the new
    API, I don't see a reason for it, user should understand the risks. And
    anyway, bitmap from other node is unrelated to this export being
    read-only or read-write.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
    Message-Id: <20220314213226.362217-3-v.sementsov-og@mail.ru>
    [eblake: Adjust S-o-b to Vladimir's new email, with permission]
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    e5fb29d5
    History
    qapi: nbd-export: allow select bitmaps by node/name pair
    Vladimir Sementsov-Ogievskiy authored
    
    Hi all! Current logic of relying on search through backing chain is not
    safe neither convenient.
    
    Sometimes it leads to necessity of extra bitmap copying. Also, we are
    going to add "snapshot-access" driver, to access some snapshot state
    through NBD. And this driver is not formally a filter, and of course
    it's not a COW format driver. So, searching through backing chain will
    not work. Instead of widening the workaround of bitmap searching, let's
    extend the interface so that user can select bitmap precisely.
    
    Note, that checking for bitmap active status is not copied to the new
    API, I don't see a reason for it, user should understand the risks. And
    anyway, bitmap from other node is unrelated to this export being
    read-only or read-write.
    
    Signed-off-by: default avatarVladimir Sementsov-Ogievskiy <vsementsov@openvz.org>
    Message-Id: <20220314213226.362217-3-v.sementsov-og@mail.ru>
    [eblake: Adjust S-o-b to Vladimir's new email, with permission]
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>