Skip to content
Snippets Groups Projects
  • Alberto Faria's avatar
    a9262f55
    block: Change blk_{pread,pwrite}() param order · a9262f55
    Alberto Faria authored
    
    Swap 'buf' and 'bytes' around for consistency with
    blk_co_{pread,pwrite}(), and in preparation to implement these functions
    using generated_co_wrapper.
    
    Callers were updated using this Coccinelle script:
    
        @@ expression blk, offset, buf, bytes, flags; @@
        - blk_pread(blk, offset, buf, bytes, flags)
        + blk_pread(blk, offset, bytes, buf, flags)
    
        @@ expression blk, offset, buf, bytes, flags; @@
        - blk_pwrite(blk, offset, buf, bytes, flags)
        + blk_pwrite(blk, offset, bytes, buf, flags)
    
    It had no effect on hw/block/nand.c, presumably due to the #if, so that
    file was updated manually.
    
    Overly-long lines were then fixed by hand.
    
    Signed-off-by: default avatarAlberto Faria <afaria@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarHanna Reitz <hreitz@redhat.com>
    Message-Id: <20220705161527.1054072-4-afaria@redhat.com>
    Signed-off-by: default avatarHanna Reitz <hreitz@redhat.com>
    a9262f55
    History
    block: Change blk_{pread,pwrite}() param order
    Alberto Faria authored
    
    Swap 'buf' and 'bytes' around for consistency with
    blk_co_{pread,pwrite}(), and in preparation to implement these functions
    using generated_co_wrapper.
    
    Callers were updated using this Coccinelle script:
    
        @@ expression blk, offset, buf, bytes, flags; @@
        - blk_pread(blk, offset, buf, bytes, flags)
        + blk_pread(blk, offset, bytes, buf, flags)
    
        @@ expression blk, offset, buf, bytes, flags; @@
        - blk_pwrite(blk, offset, buf, bytes, flags)
        + blk_pwrite(blk, offset, bytes, buf, flags)
    
    It had no effect on hw/block/nand.c, presumably due to the #if, so that
    file was updated manually.
    
    Overly-long lines were then fixed by hand.
    
    Signed-off-by: default avatarAlberto Faria <afaria@redhat.com>
    Reviewed-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarHanna Reitz <hreitz@redhat.com>
    Message-Id: <20220705161527.1054072-4-afaria@redhat.com>
    Signed-off-by: default avatarHanna Reitz <hreitz@redhat.com>