Skip to content
Snippets Groups Projects
  • Kevin Wolf's avatar
    12d5ee3a
    block: Fix -incoming with snapshot=on · 12d5ee3a
    Kevin Wolf authored
    
    The BDRV_O_INACTIVE flag should only be set for images explicitly opened
    by the user. snapshot=on needs to create a new qcow2 image and write
    some metadata to it. This is not a problem because it can't come from
    the source, so there's no reason to mark it as BDRV_O_INACTIVE, even
    though it is opened while waiting for the migration to complete.
    
    This fixes an assertion failure when -incoming and snapshot=on are
    combined.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    12d5ee3a
    History
    block: Fix -incoming with snapshot=on
    Kevin Wolf authored
    
    The BDRV_O_INACTIVE flag should only be set for images explicitly opened
    by the user. snapshot=on needs to create a new qcow2 image and write
    some metadata to it. This is not a problem because it can't come from
    the source, so there's no reason to mark it as BDRV_O_INACTIVE, even
    though it is opened while waiting for the migration to complete.
    
    This fixes an assertion failure when -incoming and snapshot=on are
    combined.
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>