Skip to content
Snippets Groups Projects
  • John Snow's avatar
    206439cd
    scripts/device-crash-test: Use a QMP timeout · 206439cd
    John Snow authored
    
    Despite all the previous fixes, it's still possible for
    device-crash-test to wedge itself in the case that QEMU terminates *so
    quickly* that it doesn't even begin a connection attempt to our QMP
    client. Python will just joyfully wait ad infinitum for a connection
    that will now never arrive.
    
    The real fix is to use asyncio to simultaneously poll both the health of
    the launched process AND the connection attempt. That's quite a bit more
    invasive than just setting a connection timeout, though.
    
    Do the very simplest thing for now.
    
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    Message-id: 20211118204620.1897674-7-jsnow@redhat.com
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    206439cd
    History
    scripts/device-crash-test: Use a QMP timeout
    John Snow authored
    
    Despite all the previous fixes, it's still possible for
    device-crash-test to wedge itself in the case that QEMU terminates *so
    quickly* that it doesn't even begin a connection attempt to our QMP
    client. Python will just joyfully wait ad infinitum for a connection
    that will now never arrive.
    
    The real fix is to use asyncio to simultaneously poll both the health of
    the launched process AND the connection attempt. That's quite a bit more
    invasive than just setting a connection timeout, though.
    
    Do the very simplest thing for now.
    
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>
    Message-id: 20211118204620.1897674-7-jsnow@redhat.com
    Signed-off-by: default avatarJohn Snow <jsnow@redhat.com>