Skip to content
Snippets Groups Projects
  • Kevin Wolf's avatar
    64537ff1
    vl: Improve error message for conflicting -incoming and -loadvm · 64537ff1
    Kevin Wolf authored
    
    Currently, the conflict between -incoming and -loadvm is only detected
    when loading the snapshot fails because the image is still inactive for
    the incoming migration. This results in a suboptimal error message:
    
    $ ./qemu-system-x86_64 -hda /tmp/test.qcow2 -loadvm foo -incoming defer
    qemu-system-x86_64: Device 'ide0-hd0' is writable but does not support snapshots
    
    Catch the situation already in qemu_validate_options() to improve the
    message:
    
    $ ./qemu-system-x86_64 -hda /tmp/test.qcow2 -loadvm foo -incoming defer
    qemu-system-x86_64: 'incoming' and 'loadvm' options are mutually exclusive
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Message-ID: <20231201142520.32255-3-kwolf@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    (cherry picked from commit 5a7f21efaf99c60614fe1967be1c0f9aa46c526e)
    Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>
    64537ff1
    History
    vl: Improve error message for conflicting -incoming and -loadvm
    Kevin Wolf authored
    
    Currently, the conflict between -incoming and -loadvm is only detected
    when loading the snapshot fails because the image is still inactive for
    the incoming migration. This results in a suboptimal error message:
    
    $ ./qemu-system-x86_64 -hda /tmp/test.qcow2 -loadvm foo -incoming defer
    qemu-system-x86_64: Device 'ide0-hd0' is writable but does not support snapshots
    
    Catch the situation already in qemu_validate_options() to improve the
    message:
    
    $ ./qemu-system-x86_64 -hda /tmp/test.qcow2 -loadvm foo -incoming defer
    qemu-system-x86_64: 'incoming' and 'loadvm' options are mutually exclusive
    
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    Message-ID: <20231201142520.32255-3-kwolf@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    (cherry picked from commit 5a7f21efaf99c60614fe1967be1c0f9aa46c526e)
    Signed-off-by: default avatarMichael Tokarev <mjt@tls.msk.ru>