Skip to content
Snippets Groups Projects
  • Eric Blake's avatar
    e18a58b4
    block: Merge .bdrv_co_writev{,_flags} in drivers · e18a58b4
    Eric Blake authored
    
    We have too many driver callback interfaces; simplify the mess
    somewhat by merging the flags parameter of .bdrv_co_writev_flags()
    into .bdrv_co_writev().  Note that as long as a driver doesn't set
    .supported_write_flags, the flags argument will be 0 and behavior is
    identical.  Also note that the public function bdrv_co_writev() still
    lacks a flags argument; so the driver signature is thus intentionally
    slightly different.  But that's not the end of the world, nor the first
    time that the driver interface differs slightly from the public
    interface.
    
    Ideally, we should be rewriting all of these drivers to use modern
    byte-based interfaces.  But that's a more invasive patch to write
    and audit, compared to the simplification done here.
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>
    e18a58b4
    History
    block: Merge .bdrv_co_writev{,_flags} in drivers
    Eric Blake authored
    
    We have too many driver callback interfaces; simplify the mess
    somewhat by merging the flags parameter of .bdrv_co_writev_flags()
    into .bdrv_co_writev().  Note that as long as a driver doesn't set
    .supported_write_flags, the flags argument will be 0 and behavior is
    identical.  Also note that the public function bdrv_co_writev() still
    lacks a flags argument; so the driver signature is thus intentionally
    slightly different.  But that's not the end of the world, nor the first
    time that the driver interface differs slightly from the public
    interface.
    
    Ideally, we should be rewriting all of these drivers to use modern
    byte-based interfaces.  But that's a more invasive patch to write
    and audit, compared to the simplification done here.
    
    Signed-off-by: default avatarEric Blake <eblake@redhat.com>
    Reviewed-by: default avatarDaniel P. Berrangé <berrange@redhat.com>
    Signed-off-by: default avatarKevin Wolf <kwolf@redhat.com>